-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new feeds for (reLAXsan,A quabus Ferries , City of Winona MN - Winona Transit Service) [SOURCES] #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! You're awesome.
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.
Examples of titles with semantic prefixes:
- fix: Fix wrong countries for some sources
- feat: Add Features and Status to MDB Schema [SOURCES]
- docs: Improvements to README.md and CONTRIBUTING.md
If your pull request includes adding or updating a source, make sure to end your pull request title with "[SOURCES]" so the GitHub workflow runs.
@AlfredNwolisa Looks good! Only outstanding step is to delete the old relaxsan feed that isn't in the spreadsheet (mdb-2026). |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@AlfredNwolisa There was an issue I didn't catch! Country code should be a 2 digit code, e.g US, not the full country name for Winona. This is a good test case to practice editing a feed with the spreadsheet. |
Hi @emmambd kindly review