Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new feeds for (reLAXsan,A quabus Ferries , City of Winona MN - Winona Transit Service) [SOURCES] #383

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

AlfredNwolisa
Copy link
Collaborator

Hi @emmambd kindly review

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! You're awesome.
We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.
Examples of titles with semantic prefixes:
- fix: Fix wrong countries for some sources
- feat: Add Features and Status to MDB Schema [SOURCES]
- docs: Improvements to README.md and CONTRIBUTING.md

If your pull request includes adding or updating a source, make sure to end your pull request title with "[SOURCES]" so the GitHub workflow runs.

@AlfredNwolisa AlfredNwolisa reopened this Jul 10, 2024
@AlfredNwolisa AlfredNwolisa marked this pull request as draft July 10, 2024 22:56
@Sergiodero Sergiodero requested a review from emmambd July 10, 2024 23:26
@AlfredNwolisa AlfredNwolisa marked this pull request as ready for review July 10, 2024 23:30
@AlfredNwolisa AlfredNwolisa self-assigned this Jul 11, 2024
@emmambd
Copy link
Contributor

emmambd commented Jul 11, 2024

@AlfredNwolisa Looks good! Only outstanding step is to delete the old relaxsan feed that isn't in the spreadsheet (mdb-2026).

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@emmambd emmambd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmambd emmambd merged commit 40930f7 into main Jul 11, 2024
8 of 9 checks passed
@emmambd emmambd deleted the 2024-07-10-SOURCES branch July 11, 2024 19:26
@emmambd
Copy link
Contributor

emmambd commented Jul 15, 2024

@AlfredNwolisa There was an issue I didn't catch! Country code should be a 2 digit code, e.g US, not the full country name for Winona. This is a good test case to practice editing a feed with the spreadsheet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants