fix(editor): CreationType update fixes

Mojang · Aug 31, 2024 · 2a6c07e · 2a6c07e
1 parent 23e03d0
commit 2a6c07e
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 4 deletions.
diff --git a/app/src/UX/ProjectItemEditor.tsx b/app/src/UX/ProjectItemEditor.tsx
@@ -171,7 +171,10 @@ export default class ProjectItemEditor extends Component<IProjectItemEditorProps
 
       const ep = this.props.activeProjectItem.effectiveEditPreference;
 
-      if (this.props.activeProjectItem.creationType !== ProjectItemCreationType.normal) {
+      if (
+        this.props.activeProjectItem.creationType !== ProjectItemCreationType.normal &&
+        this.props.activeProjectItem.creationType !== undefined
+      ) {
         readOnly = true;
       }
 

diff --git a/app/src/UX/ProjectItemList.tsx b/app/src/UX/ProjectItemList.tsx
@@ -1539,7 +1539,9 @@ export default class ProjectItemList extends Component<IProjectItemListProps, IP
     }
 
     return (
-      (projectItem.creationType === ProjectItemCreationType.normal || this.props.project.showHiddenItems) &&
+      (projectItem.creationType === undefined ||
+        projectItem.creationType === ProjectItemCreationType.normal ||
+        this.props.project.showHiddenItems) &&
       perTypeShouldShow &&
       (projectItem.itemType !== ProjectItemType.json || !fileName.startsWith(".")) && // hide files like .prettierrc.json from view
       (projectItem.itemType !== ProjectItemType.json || !fileName.startsWith("extensions")) && // hide files like extensions.json from view

diff --git a/app/src/app/Project.ts b/app/src/app/Project.ts
@@ -1471,7 +1471,7 @@ export default class Project {
     for (let i = 0; i < this.#items.length; i++) {
       const item = this.#items[i];
 
-      if (item.creationType) {
+      if (item.creationType === ProjectItemCreationType.generated) {
         await item.updateAutogenerated();
       }
 

diff --git a/app/src/app/ProjectItem.ts b/app/src/app/ProjectItem.ts
@@ -504,7 +504,11 @@ export default class ProjectItem {
   }
 
   get needsSave() {
-    if (this._file === null && this.creationType && this.storageType === ProjectItemStorageType.singleFile) {
+    if (
+      this._file === null &&
+      this.creationType === ProjectItemCreationType.generated &&
+      this.storageType === ProjectItemStorageType.singleFile
+    ) {
       return true;
     }