Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ESLint Flat Config #15

Merged
merged 7 commits into from
Feb 29, 2024
Merged

Support for ESLint Flat Config #15

merged 7 commits into from
Feb 29, 2024

Conversation

frgarc
Copy link
Contributor

@frgarc frgarc commented Feb 28, 2024

Description

Adding support to coreLint task for ESLint Flat Config files.

With this change all these ESLint config files are supported:

  • Legacy mode: .eslintrc.js
  • Flat mode: eslint.config.js, eslint.config.mjs, eslint.config.cjs

rlandav
rlandav reviewed Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@rlandav rlandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the eslint config file also be changed for this repo?

rlandav
rlandav approved these changes Feb 28, 2024
View reviewed changes
Copy link
Collaborator

@rlandav rlandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to change all [.eslintrc.js](https://github.com/Mojang/minecraft-scripting-libraries/blob/main/libraries/math/.eslintrc.js) files in this repo to the flat format as well

@frgarc
Copy link
Contributor Author

frgarc commented Feb 29, 2024

Make sure to change all [.eslintrc.js](https://github.com/Mojang/minecraft-scripting-libraries/blob/main/libraries/math/.eslintrc.js) files in this repo to the flat format as well

Done, updated all projects to use flat config

rlandav
rlandav approved these changes Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@rlandav rlandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, let me know when you want me to merge.

change/@minecraft-math-bfee3a6c-c199-4089-ae71-80d845bc0355.json Outdated Show resolved Hide resolved
@rlandav rlandav merged commit 945df92 into main Feb 29, 2024
2 checks passed
@rlandav rlandav deleted the frgarc/esLintFlat branch February 29, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlandav rlandav rlandav approved these changes

@JakeShirley JakeShirley Awaiting requested review from JakeShirley JakeShirley is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frgarc @rlandav