Csse layout 550 error #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting review @davidbrownell, @krachwal, @rfievet, @ketanbj, @varun646, @jyoung3131 |
davidbrownell
approved these changes
Nov 12, 2024
| dself = self.dict() | ||
| if version == 2: | ||
| # remove harmless empty error field that v2 won't accept. if populated, pydantic will catch it. | ||
| if dself.pop("error", None): |
There was a problem hiding this comment.
Consider removing the if statement (since it doesn't do anything) and change to dself.pop("error", None).
There was a problem hiding this comment.
fixed here and two other spots in next PR
loriab
added a commit
that referenced
this pull request
Jan 13, 2025
* remove v2.Result.error field * convert subresults for error field in procedures * enforce success in v2. test success * surveys schema_version and extras * round out survey checks for now * atspec no ver * skip a couple tests on py37 * more fixes * fix selector * py37 * another
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
v2.<>Result.errorfield and forgive its empty presence inv1.<>Result.convert_v()fnv2.<>Resultandv2.FailedOperationschema_versionstamping instead of popping the version was convenient for theconvert_vfunction when v1 and v2 were same layout. but the pop strategy might be better long-haul.Changelog description
Status