Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Csse pyd2 pull altered qcel and run pre-commit #452

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Sep 17, 2024

Description

  • set up pre-commit and run it on all files (some are excluded for stability)
  • start using a particular qcel branch loriab/csse_pyd2_shimclasses to test against
  • before merge, recheck this branch qcel target likely to be long-lived
  • fix a nwchem version case where a change in safe_versions in qcel failed here (0.7.0+N/A)

Changelog description

Status

  • Code base linted
  • Ready to go

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.08%. Comparing base (0642655) to head (cb19baa).
Report is 2 commits behind head on next2024.

Additional details and impacted files

@loriab loriab mentioned this pull request Sep 18, 2024
6 tasks
@loriab loriab changed the title pull altered qcel pull altered qcel and run pre-commit Sep 18, 2024
@loriab loriab marked this pull request as ready for review October 1, 2024 22:08
@loriab loriab changed the title pull altered qcel and run pre-commit Csse pyd2 pull altered qcel and run pre-commit Oct 1, 2024
@loriab
Copy link
Collaborator Author

loriab commented Oct 2, 2024

Requesting review @davidbrownell, @krachwal, @rfievet, @ketanbj, @varun646, @jyoung3131

- id: check-yaml
- id: check-added-large-files
args: ["--maxkb=250"]
- repo: https://github.com/Yelp/detect-secrets

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider leveraging GitHub Secret Scanning unless this action is doing something above and beyond what is done with GitHub.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, nothing special -- someone had added this to pre-commit for QCElemental, so I continued it here. These repositories aren't likely to collect secrets in any case. I've enabled the GH secret scanning at QCManyBody and will do so here and at QCEl if the other primary owner agrees.

@loriab loriab merged commit 6ceb824 into MolSSI:next2024 Oct 3, 2024
16 checks passed
@loriab loriab deleted the csse_pyd2_506 branch October 3, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants