-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Csse pyd2 pull altered qcel and run pre-commit #452
Conversation
4b5d32e
to
76b863e
Compare
Requesting review @davidbrownell, @krachwal, @rfievet, @ketanbj, @varun646, @jyoung3131 |
- id: check-yaml | ||
- id: check-added-large-files | ||
args: ["--maxkb=250"] | ||
- repo: https://github.com/Yelp/detect-secrets |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider leveraging GitHub Secret Scanning unless this action is doing something above and beyond what is done with GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, nothing special -- someone had added this to pre-commit for QCElemental, so I continued it here. These repositories aren't likely to collect secrets in any case. I've enabled the GH secret scanning at QCManyBody and will do so here and at QCEl if the other primary owner agrees.
Description
before merge, recheck this branchqcel target likely to be long-livedfix a nwchem version case where a change in safe_versions in qcel failed here (0.7.0+N/A)Changelog description
Status