-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): parameterise out github account #210
feat(ci): parameterise out github account #210
Conversation
Parameterises the `github_account` and `github_repo` used in the `molecule` test suite. Pulls these values from environment variables instead of hard coding. This makes testing more approachable for other contributors.
I think the This results in an error
Interestingly, there's a similar line in the default scenario's verify.yaml but this doesn't cause an error because it doesn't check the runners by name. This seems to be a change introduced in this commit. |
Thx @lewismiddleton. That will be probably just some leftovers from my testing. I will look on it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
b95b43c
into
MonolithProjects:master
Description
Parameterises the
github_account
andgithub_repo
used in themolecule
test suite. Pulls these values from environment variables instead of hard coding. Had to change Github Workflows to account for this change.This makes testing more approachable for other contributors as they don't have to make changes to the working directory to run tests.
Type of change
How Has This Been Tested?
I've run all 4 test scenarios against a Github org that I maintain. 3 of them (
default
,repo
,org
) passed, thecustom_env
scenario failed for an unrelated reason, I'll add a comment to this PR explaining what I think the issue is.