Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pl_PL translations #447

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add pl_PL translations #447

wants to merge 1 commit into from

Conversation

rail01
Copy link

@rail01 rail01 commented Jun 29, 2021

pl.po file containing Polish translations for paru. If strings are missing, it means that I was not sure about the context and decided not to risk incorrect translation.

Btw this program has very straightforward attitude towards plurals. This will become an issue for languages with more complex plurals, such as Polish. Just compare these two:

https://gitlab.archlinux.org/pacman/pacman/-/blob/master/src/pacman/po/pl.po#L1511

#: src/pacman/sync.c:579
#, c-format
msgid "There is %d member in group %s%s%s:\n"
msgid_plural "There are %d members in group %s%s%s:\n"
msgstr[0] "Znaleziono %d pakiet w grupie %s%s%s:\n"
msgstr[1] "Znaleziono %d pakiety w grupie %s%s%s:\n"
msgstr[2] "Znaleziono %d pakietów w grupie %s%s%s:\n"
msgstr[3] "Znaleziono %d pakietów w grupie %s%s%s:\n"

And paru's:

#: src/install.rs:1743
msgid "There are {} members in group"
msgstr "Znaleziono {} pakietów w grupie"

pl.po file containing Polish translations for paru
@Morganamilo
Copy link
Owner

How does the singular and plural become 4 translations. I'm assuming singular/plural*masc/fem. How does the code actually how which one to translate to?

@rail01
Copy link
Author

rail01 commented Jun 30, 2021

I would love to tell you, but I don't know :) I'm more of a translatior than a developer – sorry.

@seragunn
Copy link
Contributor

You mean you have a different plural for 0 items, 1 item, 2 items, 3 or more items right? Not male/female.

@Morganamilo
Copy link
Owner

That would make more sense. I assume msgstr[3] is used if count is > 3? Need to look into gettext.

@Morganamilo
Copy link
Owner

Ah, it's dependant on "Plural-Forms" at the top of the file. So the polish translation defines 4 plural forms and that maps to msgstr[n].

@Morganamilo
Copy link
Owner

Anyway I'll worry about that in a future release when all the initial translations are in place.

If you can finish the translation then please do. Otherwise I'll leave this open in case some one else can fill in the gaps.

@Cyliann
Copy link

Cyliann commented Jul 29, 2021

Polish is very complicated in therms of numerals. The are 3 plural forms for every gramatical gender (male/female/neuter).
Pakiet (package) is male type so:
1 package -> pakiet
2-4 packages -> pakiety
5+ packages -> pakietów

That's not all. If a number ends with 2, 3 or 4 it's still pakiety. Eg. 23 pakiety, but 21 pakietów.

@mskiptr
Copy link

mskiptr commented Feb 24, 2023

Just for completeness sake:

0 packages -> pakietów

1 package -> pakiet
2-4 packages -> pakiety
5+ packages -> pakietów

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants