🔀 Merge pull request #33 from Morning-Train/feature/allow-string-as-p…

…roduct

Allow parsing productNumber as string when creating ProductLine with ::new function

src/Abstracts/Endpoint.php

@@ -4,9 +4,7 @@
 
 abstract class Endpoint
 {
-    public function __construct(protected string $endpoint, protected ?array $references = null)
-    {
-    }
+    public function __construct(protected string $endpoint, protected ?array $references = null) {}
 
     public function getEndpoint(...$references): string
     {

src/Abstracts/Resource.php

@@ -75,7 +75,7 @@ protected static function resolvePropertyValue(string $property, mixed $value):
             if (! empty($attribute[0]) && ! empty($value) && is_array($value)) {
                 $resourceType = $attribute[0]->newInstance();
 
-                $collection = new Collection();
+                $collection = new Collection;
 
                 foreach ($value as $item) {
                     $collection->add(new ($resourceType->getTypeClass())($item));

src/Attributes/Resources/Create.php

@@ -7,7 +7,5 @@
 
 #[Attribute(Attribute::TARGET_CLASS)] class Create extends Endpoint
 {
-    public function __construct(protected string $endpoint)
-    {
-    }
+    public function __construct(protected string $endpoint) {}
 }

src/Attributes/Resources/Delete.php

@@ -5,6 +5,4 @@
 use Attribute;
 use Morningtrain\Economic\Abstracts\Endpoint;
 
-#[Attribute(Attribute::TARGET_CLASS)] class Delete extends Endpoint
-{
-}
+#[Attribute(Attribute::TARGET_CLASS)] class Delete extends Endpoint {}

src/Attributes/Resources/GetCollection.php

@@ -7,7 +7,5 @@
 
 #[Attribute(Attribute::TARGET_CLASS | Attribute::IS_REPEATABLE)] class GetCollection extends Endpoint
 {
-    public function __construct(protected string $endpoint)
-    {
-    }
+    public function __construct(protected string $endpoint) {}
 }

src/Attributes/Resources/GetSingle.php

@@ -7,7 +7,5 @@
 
 #[Attribute(Attribute::TARGET_CLASS)] class GetSingle extends Endpoint
 {
-    public function __construct(protected string $endpoint)
-    {
-    }
+    public function __construct(protected string $endpoint) {}
 }

src/Attributes/Resources/Properties/ApiFormatting/ResourceToPrimaryKey.php

@@ -8,9 +8,7 @@
 
 #[Attribute(Attribute::TARGET_PROPERTY)] class ResourceToPrimaryKey implements ApiFormatter
 {
-    public function __construct()
-    {
-    }
+    public function __construct() {}
 
     public function format($value): mixed
     {

src/Attributes/Resources/Properties/Filterable.php

@@ -4,6 +4,4 @@
 
 use Attribute;
 
-#[Attribute(Attribute::TARGET_PROPERTY)] class Filterable
-{
-}
+#[Attribute(Attribute::TARGET_PROPERTY)] class Filterable {}

src/Attributes/Resources/Properties/PrimaryKey.php

@@ -4,6 +4,4 @@
 
 use Attribute;
 
-#[Attribute(Attribute::TARGET_PROPERTY)] class PrimaryKey
-{
-}
+#[Attribute(Attribute::TARGET_PROPERTY)] class PrimaryKey {}

src/Attributes/Resources/Properties/Required.php

@@ -4,6 +4,4 @@
 
 use Attribute;
 
-#[Attribute(Attribute::TARGET_PROPERTY)] class Required
-{
-}
+#[Attribute(Attribute::TARGET_PROPERTY)] class Required {}

src/Attributes/Resources/Properties/ResourceType.php

@@ -7,9 +7,7 @@
 #[Attribute(Attribute::TARGET_PROPERTY)]
 class ResourceType
 {
-    public function __construct(public string $typeClass)
-    {
-    }
+    public function __construct(public string $typeClass) {}
 
     public function getTypeClass(): string
     {

src/Attributes/Resources/Properties/Sortable.php

@@ -4,6 +4,4 @@
 
 use Attribute;
 
-#[Attribute(Attribute::TARGET_PROPERTY)] class Sortable
-{
-}
+#[Attribute(Attribute::TARGET_PROPERTY)] class Sortable {}

src/Attributes/Resources/Update.php

@@ -5,6 +5,4 @@
 use Attribute;
 use Morningtrain\Economic\Abstracts\Endpoint;
 
-#[Attribute(Attribute::TARGET_CLASS)] class Update extends Endpoint
-{
-}
+#[Attribute(Attribute::TARGET_CLASS)] class Update extends Endpoint {}

src/Classes/EconomicCollectionIterator.php

@@ -18,9 +18,7 @@ class EconomicCollectionIterator implements ArrayAccess, Countable, SeekableIter
 
     protected int $currentPosition = 0;
 
-    public function __construct(protected string $self, protected string $resourceClass)
-    {
-    }
+    public function __construct(protected string $self, protected string $resourceClass) {}
 
     protected function getItem(int $position): ?Resource
     {

src/Classes/EconomicQueryBuilder.php

@@ -18,9 +18,7 @@ class EconomicQueryBuilder
 
     protected string|Endpoint $endpoint;
 
-    public function __construct(protected string $resourceClass)
-    {
-    }
+    public function __construct(protected string $resourceClass) {}
 
     public function setEndpoint(string|Endpoint $endpoint): static
     {

src/Classes/EconomicQueryFilterBuilder.php

@@ -42,9 +42,7 @@ class EconomicQueryFilterBuilder
 
     protected array $filters = [];
 
-    public function __construct(protected string $relation)
-    {
-    }
+    public function __construct(protected string $relation) {}
 
     protected function convertOperator(string $operator): string
     {

src/Classes/EconomicRelatedResource.php

@@ -12,9 +12,7 @@
  */
 class EconomicRelatedResource
 {
-    public function __construct(protected Endpoint $endpointCollection, protected Endpoint $endpointSingle, protected string $resourceClass, protected array $references)
-    {
-    }
+    public function __construct(protected Endpoint $endpointCollection, protected Endpoint $endpointSingle, protected string $resourceClass, protected array $references) {}
 
     /**
      * @return R|null

src/DTOs/Invoice/ProductLine.php

@@ -37,7 +37,7 @@ class ProductLine extends Resource
     public ?float $unitNetPrice;
 
     public static function new(
-        Product|int $product,
+        Product|int|string $product,
         float $quantity,
         float $unitNetPrice,
         ?string $description = null,

src/Resources/AccountingYear/Voucher.php

@@ -4,6 +4,4 @@
 
 use Morningtrain\Economic\Abstracts\Resource;
 
-class Voucher extends Resource
-{
-}
+class Voucher extends Resource {}

src/Resources/Customer/Total.php

@@ -4,6 +4,4 @@
 
 use Morningtrain\Economic\Abstracts\Resource;
 
-class Total extends Resource
-{
-}
+class Total extends Resource {}

src/Resources/Department.php

@@ -6,6 +6,4 @@
 use Morningtrain\Economic\Attributes\Resources\GetCollection;
 
 #[GetCollection()]
-class Department extends Resource
-{
-}
+class Department extends Resource {}

src/Traits/Resources/HasLines.php

@@ -17,7 +17,7 @@ trait HasLines
     public function addLine(ProductLine $line): static
     {
         if (is_null($this->lines)) {
-            $this->lines = new Collection();
+            $this->lines = new Collection;
         }
 
         $this->lines->add($line);

tests/Unit/ProductLineTest.php

@@ -0,0 +1,16 @@
+<?php
+
+use Morningtrain\Economic\DTOs\Invoice\ProductLine;
+use Morningtrain\Economic\Resources\Product;
+
+it('allows setting product from string', function () {
+    $productLine = ProductLine::new(
+        product: 'test',
+        quantity: 1,
+        unitNetPrice: 100,
+    );
+
+    expect($productLine->product)
+        ->toBeInstanceOf(Product::class)
+        ->productNumber->toBe('test');
+});