Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加README折叠 #289

Merged
merged 1 commit into from
Feb 14, 2024
Merged

添加README折叠 #289

merged 1 commit into from
Feb 14, 2024

Conversation

Suzukaze7
Copy link
Collaborator

添加README.md部分内容的折叠功能,fix #220

@Suzukaze7
Copy link
Collaborator Author

之前是直接merge源仓库导致的,所以sync fork只能在网页操作吗

@Mq-b
Copy link
Owner

Mq-b commented Feb 14, 2024

之前是直接merge源仓库导致的,所以sync fork只能在网页操作吗

其实我不清楚,但是这个按钮的确网页有(

@Mq-b Mq-b added the category: homework 卢瑟作业 label Feb 14, 2024
@Mq-b Mq-b merged commit 9791943 into Mq-b:main Feb 14, 2024
2 checks passed
@rsp4jack
Copy link
Collaborator

之前是直接merge源仓库导致的,所以sync fork只能在网页操作吗

应该可以直接 fasr-forward 过去。不能的话 hard reset 也可以。

@rsp4jack
Copy link
Collaborator

@Mq-b 你怎么 review 的,目录有问题。

@Mq-b
Copy link
Owner

Mq-b commented Feb 15, 2024

@Mq-b 你怎么 review 的,目录有问题。

没注意,你处理处理

@Mq-b Mq-b added the bug Something isn't working label Feb 15, 2024
@Suzukaze7
Copy link
Collaborator Author

@Mq-b 你怎么 review 的,目录有问题。

目录有啥问题(⊙o⊙)

@rsp4jack
Copy link
Collaborator

@Suzukaze7 https://github.com/Mq-b/Loser-HomeWork 你点目录里的参考答案

@Suzukaze7
Copy link
Collaborator Author

@Suzukaze7 https://github.com/Mq-b/Loser-HomeWork 你点目录里的参考答案

我在本地一直跳转不了,以为就是这样...

研究下怎么改

@Suzukaze7
Copy link
Collaborator Author

Suzukaze7 commented Feb 15, 2024

@rsp4jack 要么把所有标题挪到折叠外面,要么应该只能把目录改成 a 标签跳转到 summary

@rsp4jack
Copy link
Collaborator

你把 <details> 的 id 改成目录里的就行。

@Suzukaze7
Copy link
Collaborator Author

虽然很怪,但是也合理。md 的元素是全转成 html 的? 怎么能跟 id 对应上

@rsp4jack
Copy link
Collaborator

因为浏览器解析的是 html,你把 md 直接给浏览器看,它也看不懂啊。

@Suzukaze7
Copy link
Collaborator Author

要不要把折叠里面的二级标题的链接定向到折叠本身,比如:

+ [标准答案](#标准答案-9)
   - [`C++17` 写法](#c17-写法) 
   改成 - [`C++17` 写法](#标准答案-9) 

@rsp4jack
Copy link
Collaborator

折叠里面也没有二级标题啊。

@Suzukaze7
Copy link
Collaborator Author

次级标题,看例子就行

不改的话,折叠起来点了也会出问题

@rsp4jack
Copy link
Collaborator

所以说你把 details 的 id 改成和 toc 一样就可以了,次级标题应该折叠进 details,toc 没必要改。

@Suzukaze7 Suzukaze7 mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working category: homework 卢瑟作业
Projects
None yet
Development

Successfully merging this pull request may close these issues.

修整卢瑟作业 README.md
3 participants