Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #230 by adding f/F/t/T #296

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Kyllingene
Copy link
Contributor

@Kyllingene Kyllingene commented Dec 20, 2023

While f was already implemented, this PR implements the rest of them.

Rather than adding Motion::FindBack, FindTo, and FindToBack, I modified Motion::Find to be Find { ch: char, back: bool, to: bool }, and updated the appropriate logic.

@Kyllingene
Copy link
Contributor Author

Kyllingene commented Dec 20, 2023

Seems like the f keybinding was broken to begin with, and thus so are the rest. I'll do some debugging to see what's wrong

@Kyllingene
Copy link
Contributor Author

So it seems like, for some reason, the f keybinding and siblings aren't getting parsed properly. I checked the grammar, and the only valid search characters are alphabetical, which is clearly incorrect. Fixing the issue gives me a confusing LALRPOP error that doesn't make sense to me. I'm just going to say for now that this probably does what's intended, but a new issue should be made regarding f that blocks this.

@MrPicklePinosaur
Copy link
Owner

most likely has to do with conflicts with the grammar, keeping it alphanumerical is probably ok for now

@Kyllingene
Copy link
Contributor Author

That doesn't fix the issue that it doesn't seem to be parsing correctly anyways, regardless of what character you search for. When you press f, it eats all inputs without doing anything, until you hit escape.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants