Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctoring StrawDigi timing to shift tracks in time #1344

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

edcallaghan
Copy link
Contributor

This PR implements a module which coherently shifts the TDC values of a StrawDigiCollection, so as to shift the timing of any to-be-reconstructed tracks . This PR is marked as a draft for now; more detail will be added here before it's necessary to initiate review.

  - currently only includes tracker data products
  - currently, only StrawDigis are manipulated
  - the digital-analog-digital conversion chain needs to mature
  - the waveforms need to be manipulated
  - the reference should be the track/Aluminum intersection time
@FNALbuild
Copy link
Collaborator

Hi @edcallaghan,
You have proposed changes to files in these packages:

  • Blinding

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

⌛ The following tests have been triggered for 7f295bb: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

@FNALbuild
Copy link
Collaborator

☀️ The build tests passed at 7f295bb.

Test Result Details
test with Command did not list any other PRs to include
merge Merged 7f295bb at 38f72f8
build (prof) Log file. Build time: 04 min 17 sec
ceSimReco Log file.
g4test_03MT Log file.
transportOnly Log file.
POT Log file.
g4study Log file.
cosmicSimReco Log file.
cosmicOffSpill Log file.
ceSteps Log file.
ceDigi Log file.
muDauSteps Log file.
ceMix Log file.
rootOverlaps Log file.
g4surfaceCheck Log file.
FIXME, TODO 🔶 TODO (2) FIXME (0) in 1 files
clang-tidy 🔶 0 errors 110 warnings
whitespace check no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 7f295bb after being merged into the base branch at 38f72f8.

For more information, please check the job page here.
Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

@FNALbuild
Copy link
Collaborator

📝 The HEAD of main has changed to 5694fbe. Tests are now out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants