GH-3068 Fix icons overwriting each other if not needed #4085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zetabite
force-pushed
the
feature/pack_icon_revision
branch
from
01b97e8
to
e2448d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing icons, mmc will now create an icon, with the filename and the md5 hash of the file appeneded to it.
icon2.pngbecomesicon2_4190adsawewq.pngor similar. In case a file with that name already exists, both files are checked on their md5sum, if they equal, the new file isnt imported. If the files have different checksums, the existing file becomes reevaluated (should only happen if someone purpoesfully adds a wrong hash to a file ) and written to the actual name it should have. ideally, that should never happen.