Fix Player Name Changes #362
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I closed this earlier because I thought I had broken the |
|
Here's a build of this PR, please report any issues :) |
|
I decided to test the |
|
Is this still needed? Actually, I see that you changed to use OfflinePlayer in some areas? |
|
I suppose it's not needed, but I think this is the better way of doing things. No need to migrate on username change with this. Needs to be rebased though. |
|
Is this pull request still being worked on? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #329 by changing usernames to UUIDs where applicable.
I've included migration code starting at Line 140 in the FlatFileProfileDataSource class, this also removes the need for the PlayerPreLoginEvent which was watching for username changes.