Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
…bserver into jdc-1955-inat-import
  • Loading branch information
JoeCohen committed Jul 21, 2024
2 parents f71e7cb + 6840c56 commit 9637994
Show file tree
Hide file tree
Showing 17 changed files with 3,647 additions and 3,631 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci_rails.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@ jobs:
run: bundle exec rails test:all

# https://github.com/marketplace/actions/coveralls-github-action
- name: Coveralls
uses: coverallsapp/github-action@master
- name: Coveralls GitHub Action
uses: coverallsapp/github-action@main
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
path-to-lcov: ./coverage/lcov/lcov.info
Expand Down
232 changes: 104 additions & 128 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,17 @@
# This configuration was generated by
# `rubocop --auto-gen-config --auto-gen-only-exclude --no-exclude-limit`
# on 2024-02-21 17:54:32 UTC using RuboCop version 1.60.2.
# `rubocop --auto-gen-config`
# on 2024-07-18 12:46:04 UTC using RuboCop version 1.65.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
# versions of RuboCop, may require this file to be generated again.

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Layout/EmptyLineAfterMagicComment:
Exclude:
- 'config/initializers/permissions_policy.rb'

# Offense count: 10
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: Max, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
Expand All @@ -14,7 +20,13 @@ Layout/LineLength:
Exclude:
- 'lib/core_extensions/action_view/log_subscriber.rb'

## Offense count: 3
# Offense count: 2
# Configuration parameters: DebuggerMethods, DebuggerRequires.
Lint/Debugger:
Exclude:
- 'test/session_extensions.rb'

# Offense count: 3
Lint/DuplicateMethods:
Exclude:
- 'app/classes/query/modules/active_record.rb'
Expand Down Expand Up @@ -44,6 +56,12 @@ Lint/NonLocalExitFromIterator:
Exclude:
- 'test/general_extensions.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Lint/RedundantCopDisableDirective:
Exclude:
- 'app/helpers/matrix_box_helper.rb'

# Offense count: 1
Lint/RescueException:
Exclude:
Expand All @@ -64,14 +82,15 @@ Lint/SuppressedException:

# Offense count: 5
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: AutoCorrect.
Lint/UselessMethodDefinition:
Exclude:
- 'app/classes/query/location_by_editor.rb'
- 'test/models/auto_complete_test.rb'

# Offense count: 8
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: CheckForMethodsWithNoSideEffects.
# Configuration parameters: AutoCorrect, CheckForMethodsWithNoSideEffects.
Lint/Void:
Exclude:
- 'app/classes/mo_paginator.rb'
Expand All @@ -80,63 +99,40 @@ Lint/Void:
- 'app/classes/query/modules/sequence_operators.rb'
- 'app/models/observation.rb'

# Offense count: 311
# Offense count: 343
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
Metrics/AbcSize:
Max: 78

# Offense count: 29
# Offense count: 31
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
# AllowedMethods: refine
Metrics/BlockLength:
Max: 248

# Offense count: 7
# Configuration parameters: CountBlocks, Max.
# Offense count: 1
# Configuration parameters: CountBlocks, CountModifierForms.
Metrics/BlockNesting:
Exclude:
- 'app/classes/tree.rb'
- 'app/controllers/observations_controller/form_helpers.rb'
- 'test/controller_extensions.rb'
Max: 4

# Offense count: 7
# Offense count: 4
# Configuration parameters: CountComments, Max, CountAsOne.
Metrics/ClassLength:
Exclude:
- 'app/classes/site_data.rb'
- 'app/classes/textile.rb'
- 'app/extensions/string_extensions.rb'
- 'app/models/abstract_model.rb'
- 'app/models/description.rb'
- 'app/models/location.rb'
- 'app/models/user.rb'

# Offense count: 113
# Offense count: 118
# Configuration parameters: AllowedMethods, AllowedPatterns.
Metrics/CyclomaticComplexity:
Max: 28

# Offense count: 21
# Offense count: 19
# Configuration parameters: CountComments, Max, CountAsOne, AllowedMethods, AllowedPatterns.
Metrics/MethodLength:
Exclude:
- 'app/classes/query/modules/joining.rb'
- 'app/classes/query/modules/sql.rb'
- 'app/classes/site_data.rb'
- 'app/classes/tree.rb'
- 'app/controllers/concerns/descriptions.rb'
- 'app/controllers/concerns/descriptions/permissions.rb'
- 'app/controllers/concerns/descriptions/publish.rb'
- 'app/controllers/locations_controller.rb'
- 'app/controllers/names/eol_data/preview_controller.rb'
- 'app/extensions/symbol_extensions.rb'
- 'app/helpers/pagination_helper.rb'
- 'app/models/language_exporter.rb'
- 'app/models/location.rb'
- 'app/models/name/notify.rb'
- 'app/models/name/parse.rb'
- 'app/models/name_sorter.rb'
- 'script/bulk_name_change'
Enabled: false

# Offense count: 4
# Configuration parameters: CountComments, Max, CountAsOne.
Expand All @@ -148,22 +144,16 @@ Metrics/ModuleLength:
- 'app/models/name/parse.rb'

# Offense count: 8
# Configuration parameters: Max, CountKeywordArgs, MaxOptionalParameters.
# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
Metrics/ParameterLists:
Exclude:
- 'app/classes/mappable/minimal_location.rb'
- 'app/models/queued_email/name_change.rb'
- 'script/mushroom_mapper.rb'
- 'test/controller_extensions.rb'
- 'test/controllers/projects/members_controller_test.rb'
- 'test/models/collapsible_map_test.rb'
Max: 9

# Offense count: 90
# Offense count: 91
# Configuration parameters: AllowedMethods, AllowedPatterns.
Metrics/PerceivedComplexity:
Max: 29

# Offense count: 11
# Offense count: 10
Naming/AccessorMethodName:
Exclude:
- 'app/classes/eol_data.rb'
Expand All @@ -188,57 +178,22 @@ Naming/HeredocDelimiterNaming:
# AllowedMethods: is_a?
# MethodDefinitionMacros: define_method, define_singleton_method
Naming/PredicateName:
Exclude:
- 'app/classes/eol_data.rb'
- 'app/classes/pattern_search/observation.rb'
- 'app/classes/run_level.rb'
- 'app/classes/tree.rb'
- 'app/controllers/api2_controller.rb'
- 'app/controllers/application_controller.rb'
- 'app/extensions/array_extensions.rb'
- 'app/extensions/hash_extensions.rb'
- 'app/extensions/string_extensions.rb'
- 'app/extensions/symbol_extensions.rb'
- 'app/helpers/descriptions_helper.rb'
- 'app/models/abstract_model.rb'
- 'app/models/description.rb'
- 'app/models/location.rb'
- 'app/models/name/lifeform.rb'
- 'app/models/name/spelling.rb'
- 'app/models/name/taxonomy.rb'
- 'app/models/name_parse.rb'
- 'app/models/observation.rb'
- 'app/models/project.rb'
Enabled: false

# Offense count: 125
# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
# SupportedStyles: snake_case, normalcase, non_integer
# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
Naming/VariableNumber:
Exclude:
- 'app/controllers/info_controller.rb'
- 'app/controllers/support_controller.rb'
- 'app/models/naming.rb'
- 'app/models/vote.rb'
- 'test/controllers/comments_controller_test.rb'
- 'test/controllers/lookups_controller_test.rb'
- 'test/controllers/names/synonyms_controller_test.rb'
- 'test/controllers/support_controller_test.rb'
- 'test/mailers/application_mailer_test.rb'
- 'test/mailers/queued_email_test.rb'
- 'test/models/api2_test.rb'
- 'test/models/name_sorter_test.rb'
- 'test/models/name_test.rb'
- 'test/models/observation_test.rb'
- 'test/models/query_test.rb'
- 'test/system/observation_show_system_test.rb'
Enabled: false

# Offense count: 1
# Offense count: 2
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
Rails/Blank:
Exclude:
- 'app/controllers/application_controller.rb'
- 'app/models/image.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Expand Down Expand Up @@ -268,7 +223,7 @@ Rails/FindEach:
- 'test/controllers/herbaria_controller_test.rb'
- 'test/models/localization_files_test.rb'

# Offense count: 46
# Offense count: 45
# Configuration parameters: Include.
# Include: app/models/**/*.rb
Rails/HasManyOrHasOneDependent:
Expand All @@ -288,6 +243,14 @@ Rails/HelperInstanceVariable:
Exclude:
- 'app/helpers/application_helper.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle.
# SupportedStyles: numeric, symbolic
Rails/HttpStatus:
Exclude:
- 'test/controllers/images_controller_test.rb'

# Offense count: 2
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: Include.
Expand Down Expand Up @@ -350,6 +313,20 @@ Security/Eval:
Exclude:
- 'script/config.rb'

# Offense count: 2
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowOnlyRestArgument, UseAnonymousForwarding, RedundantRestArgumentNames, RedundantKeywordRestArgumentNames, RedundantBlockArgumentNames.
# RedundantRestArgumentNames: args, arguments
# RedundantKeywordRestArgumentNames: kwargs, options, opts
# RedundantBlockArgumentNames: blk, block, proc
Style/ArgumentsForwarding:
Exclude:
- 'app/models/image.rb'

# Offense count: 70
Style/ClassVars:
Enabled: false

# Offense count: 8
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/CombinableLoops:
Expand All @@ -372,6 +349,20 @@ Style/IfUnlessModifier:
Exclude:
- 'lib/core_extensions/action_view/log_subscriber.rb'

# Offense count: 11
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/MapIntoArray:
Exclude:
- 'app/extensions/symbol_extensions.rb'
- 'app/helpers/descriptions_helper.rb'
- 'app/helpers/tabs/locations_helper.rb'
- 'app/helpers/title_and_tabset_helper.rb'
- 'app/helpers/user_stats_helper.rb'
- 'app/models/name/spelling.rb'
- 'app/models/queued_email.rb'
- 'app/models/vote.rb'
- 'test/general_extensions.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowedMethods, AllowedPatterns.
Expand All @@ -395,39 +386,17 @@ Style/Next:

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: MinDigits, Strict, AllowedNumbers, AllowedPatterns.
# Configuration parameters: Strict, AllowedNumbers, AllowedPatterns.
Style/NumericLiterals:
Exclude:
- 'app/controllers/application_controller.rb'
MinDigits: 7

# Offense count: 49
# Configuration parameters: AllowedMethods.
# AllowedMethods: respond_to_missing?
Style/OptionalBooleanParameter:
Exclude:
- 'app/classes/pattern_search/term.rb'
- 'app/classes/query/modules/sequence_operators.rb'
- 'app/classes/query/modules/sql.rb'
- 'app/controllers/application_controller.rb'
- 'app/extensions/string_extensions.rb'
- 'app/extensions/symbol_extensions.rb'
- 'app/helpers/content_helper.rb'
- 'app/helpers/object_link_helper.rb'
- 'app/models/location.rb'
- 'app/models/name/change.rb'
- 'app/models/name/parse.rb'
- 'app/models/queued_email.rb'
- 'app/models/queued_email/name_change.rb'
- 'app/models/visual_group.rb'
- 'app/models/visual_model.rb'
- 'script/download_symbiota.rb'
- 'test/capybara_session_extensions.rb'
- 'test/check_for_unsafe_html.rb'
- 'test/controllers/donations_controller_test_helpers.rb'
- 'test/session_extensions.rb'
- 'test/session_form_extensions.rb'
Enabled: false

# Offense count: 10
# Offense count: 9
# This cop supports safe autocorrection (--autocorrect).
Style/RedundantParentheses:
Exclude:
Expand All @@ -438,7 +407,6 @@ Style/RedundantParentheses:
- 'app/helpers/title_and_tabset_helper.rb'
- 'app/models/name.rb'
- 'test/controller_extensions.rb'
- 'test/controllers/emails_controller_test.rb'

# Offense count: 1
# This cop supports safe autocorrection (--autocorrect).
Expand Down Expand Up @@ -472,19 +440,27 @@ Style/SlicingWithRange:
# This cop supports unsafe autocorrection (--autocorrect-all).
# Configuration parameters: Mode.
Style/StringConcatenation:
Enabled: false

# Offense count: 3
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
# SupportedStyles: single_quotes, double_quotes
Style/StringLiterals:
Exclude:
- 'app/classes/labels.rb'
- 'app/extensions/string_extensions.rb'
- 'app/helpers/application_helper.rb'
- 'app/helpers/descriptions_helper.rb'
- 'app/helpers/suggestions_helper.rb'
- 'app/helpers/versions_helper.rb'
- 'app/models/comment/callbacks.rb'
- 'app/models/interest.rb'
- 'app/models/language_exporter.rb'
- 'app/models/name/parse.rb'
- 'app/models/rss_log.rb'
- 'config/unicorn.rb'
- 'config/unicorn_dev.rb'
- 'lib/tasks/lang.rake'
- 'script/refresh_name_lister_cache'
- 'app/classes/checklist.rb'

# Offense count: 14
# This cop supports safe autocorrection (--autocorrect).
Style/SuperArguments:
Exclude:
- 'app/classes/api2/error/create_failed.rb'
- 'app/classes/report/base_table.rb'
- 'app/classes/report/darwin/images.rb'
- 'app/classes/report/darwin/observations.rb'
- 'app/classes/report/darwin/taxa.rb'
- 'app/classes/report/dwca.rb'
- 'app/classes/report/zip_report.rb'
- 'app/models/field_slip_job_tracker.rb'
- 'app/models/image.rb'
- 'test/functional_test_case.rb'
Loading

0 comments on commit 9637994

Please sign in to comment.