map
, geocode
, autocompleter
Stimulus refactor from actions
to outlets
#2293
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the way map form Stimulus controllers call each other's methods, so that they call the method of the specific controller instance they need. This is necessary for forms where there is more than one autocompleter/map pair on the same page, so that they don't get their signals crossed. Also just seems like better code.
Changes from
dispatch
ing JSevents
, which may be picked up by all controllers on the page (and can only be routed to controllers by type), to calling methods on the controller itself via that controller'soutlet
identified by a unique id.Also moves the
autocompleter_field
helper method and its helpers to a separate file.