Observe todo file's Exclude's #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RuboCop was ignoring some of the todo file's Exclude's. This PR fixes most of that - Applies the workaround suggested [here](rubocop/rubocop#13091 (comment)) and [here](rubocop/rubocop#9325 (comment)) - regenerates RuboCop todo file - removes now-unnecessary `disable`'s in `app/helpers/forms_helper.rb` - inlines the remaing `disable`; using the inline gives us one fewer place to change in case we want to remove this temporararily or permanently.
|
@nimmolo: This mostly solves the problem we discussed. |
nimmolo
approved these changes
Aug 9, 2024
|
Thanks for doing this, Joe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RuboCop was ignoring some of the todo file's Exclude's. This PR fixes most of that
disable's inapp/helpers/forms_helper.rbdisable; using the inline gives us one fewer place to change in case we want to remove this temporararily or permanently.