Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App-wide - Give better "object created" notices #2333

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

nimmolo
Copy link
Contributor

@nimmolo nimmolo commented Aug 24, 2024

Currently the flash just says "Successfully created location" (or other object), but i'm encountering cases where that could be ambiguous. This PR changes the flash to print the object's text_name also, if it exists. Otherwise it defaults to the general message.

@nimmolo nimmolo marked this pull request as ready for review August 24, 2024 21:35
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 93.457% (-0.003%) from 93.46%
when pulling 52e5aa7 on better-created-flash
into b9575ac on main.

@nimmolo nimmolo merged commit 69bdbd8 into main Aug 24, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants