Emoji's in Comments #2477
Draft
Emoji's in Comments #2477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevents error from being thrown when someone uses an emoji in a Comment - Changes Comments table charset and collation - Delivers #2077
This comment was marked as resolved.
This comment was marked as resolved.
|
Oh. Trilogy is complaining about RssLog Update (1.3ms) UPDATE `rss_logs` SET `rss_logs`.`notes` = '20241008224229 log_comment_added summary 🥵 user Joe%20Cohen\n20241008224054 ...So I need to also migrate the |
- Fixes Trilogy Error in manual test on prior commit. (The rss_log.notes column must be able to include all chars used in comments.)
|
I'm having second thoughts about this PR (and about @mo-nathan's suggestion of "migrating the entire database to use utf8mb4 and also standardize the collation on utf8mb4_0900_ai_ci, which are the current Rails standards." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual Test
Create a comment with some emoji's.
Expected result: Comment is saved without throwing an error.