Address some of the AREL deprecation warnings

[mo-nathan]

No description provided.

[coveralls]

coverage: 93.509%. remained the same
when pulling 2c75f02 on njw-arel-warnings
into 372af50 on main.

[nimmolo]

The other method that is throwing a ton of warnings is batch_lookup_all_matches in models/name/taxonomy.rb

[nimmolo]

I merged this already into #2621, and took your lead of more closely examining all my methods that were now throwing these warnings, to check for reasons they could make Arel grumpy.

They primarily seemed to come from or clauses or joins where two scopes had incompatible ordering conditions, because of the new default ordering scopes on that PR. I examined the AR and added reorder("") or unscoped to these where it seemed right, and the warnings are down from 1700 to 100.

-    matches = Name.where(search_name: name2) if parse&.author.present?
-    matches = Name.where(text_name: name2) if matches.empty?
+    matches = Name.unscoped.where(search_name: name2) if parse&.author.present?
+    matches = Name.unscoped.where(text_name: name2) if matches.empty?

    Name.unscoped.
      where(Name[:correct_spelling_id].coalesce(Name[:id]).
            in(limited_id_set(ids))).
      pluck(*minimal_name_columns)

Note that help is on the way, there's a PR on arel_extensions gem to stop propagation of these warnings.

[mo-nathan]

I don't understand your explanation. I'll have to dig into it.