This repository has been archived by the owner on Apr 12, 2019. It is now read-only.
Fixed worldcat #91
Open
Fixed worldcat #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kordianbruck
suggested changes
May 4, 2017
| if (linkCounter > total_links) { | ||
| // worldcat only shows the first 5000 pages | ||
| console.log(linkCounter) | ||
| if (linkCounter == 500) { |
There was a problem hiding this comment.
Theres a 0 missing here no?
There was a problem hiding this comment.
Nope, that's right as we get 10 entries per link, so thats 500*10=5000 in total.
But I just removed an unnecessary comment from the cli.js that is no longer needed (because earlier the script ran out of RAM )
kordianbruck
approved these changes
Jun 2, 2017
|
@TimHenkelmann can we still merge this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worldcat only displays the first 5000 entries (https://www.worldcat.org/search?q=dt%3Asco&fq=yr%3A1800&dblist=638&start=4991 gives the same results as https://www.worldcat.org/search?q=dt%3Asco&fq=yr%3A1800&dblist=638&start=10000). This resulted in tons of duplicates, therefore a hard limit of 5000 entries was implemented.
... sorry @kordianbruck you should not have trusted me! ;)