Merge pull request #649 from MyPureCloud/feature/COMUI-3148

fix(table-toolbar): fix console errors when slots are absent
MyPureCloud · Oct 9, 2024 · e410f81 · e410f81
2 parents dc6f0ae + f15403f
commit e410f81
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/...sys-spark-components/src/components/stable/gux-table-toolbar/gux-table-toolbar.service.ts b/...sys-spark-components/src/components/stable/gux-table-toolbar/gux-table-toolbar.service.ts
@@ -21,6 +21,11 @@ export function setActionsIconOnlyProp(
 ): void {
   actionSets
     .flat()
-    .filter(action => action !== null && !action.hasAttribute('icon-only'))
+    .filter(
+      action =>
+        action !== null &&
+        action !== undefined &&
+        !action?.hasAttribute('icon-only')
+    )
     .forEach(action => (action.iconOnly = iconOnly));
 }
diff --git a/...es/genesys-spark-components/src/components/stable/gux-table-toolbar/gux-table-toolbar.tsx b/...es/genesys-spark-components/src/components/stable/gux-table-toolbar/gux-table-toolbar.tsx
@@ -98,14 +98,15 @@ export class GuxTableToolbar {
     return this.root?.querySelector('gux-table-toolbar-custom-action[slot]');
   }
 
-  get permanentActions(): HTMLGuxTableToolbarCustomActionElement[] | null {
+  get permanentActions(): HTMLGuxTableToolbarCustomActionElement[] {
     if (this.permanentSlot?.hasChildNodes) {
       return Array.from(
         this.permanentSlot?.querySelectorAll(
           'gux-table-toolbar-action, gux-table-toolbar-custom-action'
         )
       );
     }
+    return [];
   }
 
   get menuActionsItems(): HTMLGuxTableToolbarCustomActionElement[] | null {
@@ -118,27 +119,29 @@ export class GuxTableToolbar {
     }
   }
 
-  get contextualActions(): HTMLGuxTableToolbarCustomActionElement[] | null {
+  get contextualActions(): HTMLGuxTableToolbarCustomActionElement[] {
     if (this.contextualSlot?.hasChildNodes) {
       return Array.from(
         this.contextualSlot?.querySelectorAll(
           'gux-table-toolbar-action, gux-table-toolbar-custom-action'
         )
       );
     }
+    return [];
   }
 
-  get filterActions(): HTMLGuxTableToolbarCustomActionElement[] | null {
+  get filterActions(): HTMLGuxTableToolbarCustomActionElement[] {
     if (this.filterSlot?.hasChildNodes) {
       return Array.from(
         this.filterSlot?.querySelectorAll(
           'gux-table-toolbar-action, gux-table-toolbar-custom-action'
         )
       );
     }
+    return [];
   }
 
-  get allFilterContextual(): HTMLGuxTableToolbarCustomActionElement[] | null {
+  get allFilterContextual(): HTMLGuxTableToolbarCustomActionElement[] {
     return this.filterActions?.concat(this.contextualActions);
   }