feat(form-field-time-zone-picker) - addition of form-field-time-zone-picker component #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-2316 |
| <fieldset> | ||
| <legend>Label Above</legend> | ||
| <gux-form-field-time-zone-picker label-position="above"> | ||
| <gux-time-zone-picker-beta |
There was a problem hiding this comment.
@gavin-everett-genesys could we have just 1 component instead of 2 for the time zone picker logic, since gux-time-zone-picker-beta is always going to be the child of gux-form-field-time-zone-picker? What's the reasoning behind having 2 separate components?
There was a problem hiding this comment.
You could bring this up in standup, but I think the form-field acts as a wrapper which includes the different states like error, required etc.
daragh-king-genesys
approved these changes
Oct 16, 2023
…icker addition of form-field-time-zone-picker COMUI-2316
gavin-everett-genesys
force-pushed
the
feature/COMUI-2316
branch
from
9a757d8
to
5b14a87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMUI-2316