refactor(pagination): sync migration guide #22
Conversation
|
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-2263_v2 |
| ## Overview | ||
|
|
||
| - `gux-pagination` is transitioning to `gux-pagination-legacy` | ||
| - `gux-pagination-beta` is transitioning to `gux-pagination` which will have a new refreshed design and includes a new property `go-to-page` which allows a user to search for a page click [here](./readme.md) |
There was a problem hiding this comment.
Have a look at @katie-bobbe-genesys 's gux-modal migration guide in this PR https://github.com/MyPureCloud/genesys-spark/pull/17/files. I think it is a good approach to changes like this.
| - </gux-pagination> | ||
| + </gux-pagination-legacy> |
There was a problem hiding this comment.
Do we need to add this </gux-pagination-legacy> line here or can it be removed?
There was a problem hiding this comment.
I would remove the closing tags from L20 and L21 and keep them here after the ....
| - </gux-pagination> | ||
| + </gux-pagination-legacy> |
There was a problem hiding this comment.
I would remove the closing tags from L20 and L21 and keep them here after the ....
|
|
||
| Steps: | ||
|
|
||
| - No changes required |
There was a problem hiding this comment.
The layout options have changed. expanded, full and small -> advanced and simple. I think we recommend changing expanded and full to advanced and small to simple.
gavin-everett-genesys
force-pushed
the
feature/COMUI-2263_v2
branch
from
6bcd248
to
d64f2f8
Compare
gavin-everett-genesys
requested review from
daragh-king-genesys and
jason-evans-genesys
sync migration guide COMUI-2263
gavin-everett-genesys
force-pushed
the
feature/COMUI-2263_v2
branch
from
c0c0a44
to
98a54fa
Compare
sync migration guide
Open to changes to the guide :)
COMUI-2263