Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(blank-state) - tokens removed/updated #586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gavin-everett-genesys
Copy link
Collaborator

I was just wondering when I run new-tokens-data should the old files be updating as-well for example the tokens will still exist in _gse-ui-feedback.scss or is it okay for those files to go out of sync.

Copy link

github-actions bot commented Sep 5, 2024

@321gillian
Copy link
Collaborator

I was just wondering when I run new-tokens-data should the old files be updating as-well for example the tokens will still exist in _gse-ui-feedback.scss or is it okay for those files to go out of sync.

I think on the UX side they need to update the data-old/tokens.json file as well as the new stuff. Had a similar thing in the form field gap changes lately

@VirtualClover
Copy link
Collaborator

cc. @MonseGarciaLimon

@daragh-king-genesys
Copy link
Collaborator

@gavin-everett-genesys can you rebase this on main

removed border-radius token: blank_state.border_radius (8px)
@gavin-everett-genesys gavin-everett-genesys force-pushed the feature/GDS-2623/BlankState-RemoveBackgroundColor branch from a53dc79 to 1994b3c Compare September 6, 2024 08:42
Copy link

github-actions bot commented Sep 6, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants