[WIP]style(beta): use logical properties #613
Conversation
|
Demo will be published at https://apps.inindca.com/common-ui-docs/genesys-webcomponents/feature/COMUI-3096 |
github-actions
bot
requested review from
jason-evans-genesys and
katie-bobbe-genesys
|
I would have expected to see a change here and then running the linter sort out the actual scss files |
321gillian
force-pushed
the
feature/COMUI-3096
branch
from
23d2ede
to
aa42c18
Compare
321gillian
changed the title
321gillian
changed the title
|
Some issues here with popovers and the toggle. Looking into them. |
321gillian
force-pushed
the
feature/COMUI-3096
branch
from
b87eab0
to
e2fb50f
Compare
...s-spark-components/src/components/stable/gux-toggle/gux-toggle-slider/gux-toggle-slider.scss
Outdated
Show resolved
Hide resolved
| // TODO: Use :dir() selector instead when Chrome improves support for it | ||
| const compStyles = window.getComputedStyle(this.checkboxElement); | ||
| this.direction = compStyles.direction; |
There was a problem hiding this comment.
flagging manual changes in this file
321gillian
force-pushed
the
feature/COMUI-3096
branch
from
e0c88c1
to
d04cd27
Compare
| "plugins": ["stylelint-use-logical-spec"], | ||
| "rules": { | ||
| "liberty/use-logical-spec": true | ||
| } |
There was a problem hiding this comment.
Looking at this PR again I think we should do this in a few PRs over a few weeks to reduce the risk. We are also not going to want to change the legacy components at all so we will need to have an override for that.
See can you find a config that changes about 40 files. Also have the example.html files changes in their own PR as they are not that critical.
There was a problem hiding this comment.
Was thinking it might be good to start with beta components and go from there.
✅ Closes: COMUI-3096
321gillian
force-pushed
the
feature/COMUI-3096
branch
from
d04cd27
to
c4d2c07
Compare
321gillian
changed the title
321gillian
changed the title
|
I tested all the components that this PR touched and I also did not see any regressions. |
This is just kind of a POC for now until I get a bit of testing done with a native user of rtl. Don't panic when you see all the additions.
✅ Closes: COMUI-3096