DO NOT MERGE Refactor/devtooling 724 Outbound Messaging Campaign #1154
+1,320
−644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutisuryawanshigenesys
requested review from
dginty4,
carnellj-genesys,
HemanthDogiparthi12,
charliecon and
kavinbalagen
as code owners
shrutisuryawanshigenesys
changed the title
shrutisuryawanshigenesys
changed the title
shrutisuryawanshigenesys
changed the title
charliecon
force-pushed
the
dev
branch
2 times, most recently
from
8cd50c0
to
96ca58b
Compare
carnellj-genesys
approved these changes
Aug 5, 2024
genesyscloud/outbound_messagingcampaign/genesyscloud_outbound_messagingcampaign_init_test.go
Show resolved
Hide resolved
| `callable_time_set_id`: {RefType: "genesyscloud_outbound_callabletimeset"}, | ||
| `email_config.from_address.route_id`: {RefType: "genesyscloud_routing_email_route"}, | ||
| `email_config.from_address.domain_id`: {RefType: "genesyscloud_routing_email_domain"}, | ||
| // /api/v2/responsemanagement/responses/{responseId} |
There was a problem hiding this comment.
Why is this here? Shoudl we remove this comment . Seems like this is not needed and was left in from previous work
|
Hey Shruti, We need to get the merge conflicts resolve here :) _ John |
|
@shrutisuryawanshigenesys Remind me what the status of this PR is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.