-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/devtooling 734 Outbound Digital RuleSet #1250
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutisuryawanshigenesys
requested review from
dginty4,
carnellj-genesys,
HemanthDogiparthi12,
charliecon and
kavinbalagen
as code owners
September 10, 2024 06:27
dginty4
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to add the resource to tf_exporter_resource_test
genesyscloud/outbound_digitalruleset/genesyscloud_outbound_digitalruleset_init_test.go
Outdated
Show resolved
Hide resolved
genesyscloud/outbound_digitalruleset/resource_genesyscloud_outbound_digitalruleset_schema.go
Outdated
Show resolved
Hide resolved
carnellj-genesys
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shrutisuryawanshigenesys just need to remove the extraneous //TODO tag
genesyscloud/outbound_digitalruleset/genesyscloud_outbound_digitalruleset_init_test.go
Outdated
Show resolved
Hide resolved
charliecon
changed the title
Feat/devtooling 734 Outbound Digital RuleSet
[do not merge (testing dev for release)] Feat/devtooling 734 Outbound Digital RuleSet
Sep 24, 2024
charliecon
changed the title
[do not merge (testing dev for release)] Feat/devtooling 734 Outbound Digital RuleSet
Feat/devtooling 734 Outbound Digital RuleSet
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.