Bug/devtooling 831 #1269
Bug/devtooling 831 #1269
Conversation
kavinbalagen
requested review from
dginty4,
carnellj-genesys,
HemanthDogiparthi12,
charliecon and
BrianMoyles
as code owners
| @@ -181,3 +181,15 @@ func GenerateColumnStatus(column, contactable string) string { | |||
| contactable = %s | |||
| }`, column, contactable) | |||
| } | |||
|
|
|||
| func createComplexContact(contactListId, contactId string) string { | |||
There was a problem hiding this comment.
I think a new export test would be a good idea, at least so that if this code is edited in the future, we will know that something has broken.
We could create two contact lists, with the IDs of the contacts being the same in both lists. Then verify that the right number of resources were exported.
Since the id field in the contacts resource is read-only, we can either allow the user to provide the value with a new field contact_id, or use a helper function in the tests to seed the contact list with contacts (the existing function addContactsToContactList is example of how you can accomplish this). I think the first option is a better
| } | ||
|
|
||
| func splitComplexContact(complexContact string) (string, string) { | ||
| if strings.Contains(complexContact, ":") { |
There was a problem hiding this comment.
add delimiter as a constant, in the package so that test cases also would refer the same everywhere.
|
@kavinbalagen Can you please resolve the merge conflicts so we can merge this before you leave :) |
done! |
No description provided.