Devtooling 843 remove log.fatalf #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmat to make it easier to parse and do analysis on
…g log.Fatal. This crashes the provider and does not allow for a clean shutdown of the provider
carnellj-genesys
requested review from
dginty4,
HemanthDogiparthi12,
charliecon,
kavinbalagen and
BrianMoyles
as code owners
There was a problem hiding this comment.
So the only place where I kept the log.Fatals is in the test cases and then in the provider or exporter where it truly makes sense. We want to make sure that in situations where the provider can not start up we want to crash, but for resource errors we need to handle them as errors and follow standard patterns
...d/recording_media_retention_policy/resource_genesyscloud_recording_media_retention_policy.go
Show resolved
Hide resolved
charliecon
reviewed
Oct 16, 2024
...d/recording_media_retention_policy/resource_genesyscloud_recording_media_retention_policy.go
Show resolved
Hide resolved
...rding_media_retention_policy/resource_genesyscloud_recording_media_retention_policy_utils.go
Show resolved
Hide resolved
...rding_media_retention_policy/resource_genesyscloud_recording_media_retention_policy_utils.go
Show resolved
Hide resolved
...rding_media_retention_policy/resource_genesyscloud_recording_media_retention_policy_utils.go
Show resolved
Hide resolved
charliecon
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.