-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for formatting Slovenian #136
Conversation
After all, the upcoming release is v0.2.3, and a pending refactor will make it 0.3.0 👅 so "slow and steady" is still the name of the game in most languages. At any rate, LF's a small team, so code review might take a little while. But I can see that you're localizing the right things, in what looks like the right way, and you've had success using the functions, so I'm gonna seize the initiative and give you your Hacktoberfest credit. I imagine @krisgesling will be along to speak to the CLA, and anything else that might need saying from Mycroft-the-company's perspective (I'm not an employee, just a collaborator on this package.) |
CLA received, and you've been added to our list of excellent humans, thanks! |
Alright. I've rebased this for compatibility with LF 0.3+ @filips123 if you wouldn't mind checking out that branch (ChanceNCounter/format-slovenian) and ensuring that everything works, you can --force push it on top of this PR branch (I didn't wanna force-push someone else's repo) It might need some touching up to conform with @JarbasAl's unified formatting and locations, I haven't looked yet. I've just done the basic rebase and integration. |
0bcde4a
to
6813b4b
Compare
Thanks! I tested it and everything seems to work correctly. I also have an idea how to improve plural support in |
@krisgesling @JarbasAl Now having worked on this PR a little, I'd appreciate another look before it gets merged. Also, it might not be conformant with Jarbas' new layout. The localizer's finding everything, though, so either Jarbas is magic, everything's in the right place, or both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nitpicks, but overall looks good
lingua_franca/lang/parse_sl.py is an empty file, can you at least add a comment, TODO implement parsing function
It can probably be addressed in another PR, but, at the moment, If it doesn't, this happens:
whereas, with the empty file,
Edit: #160 filed to make this unnecessary. |
@ChanceNCounter i still think it's good for the file to exist, but with a TODO comment so devs can grep for TODO but i agree with #160 , should not be mandatory |
Squashing manually to preserve authorship, then merging |
efda8f4
to
04304a6
Compare
This adds support for formatting Slovenian numbers, dates, times and durations. It seems to work on all examples and tests I tested.
But there is one small problem that
nice_duration
only supports basic plural form while Slovenian uses many plural forms. I was able to fix this in other functions, butnice_duration
relies on plural files (day.word
anddays.word
, etc.), so there will be some wrong plural forms in some cases. However, it should still be understandable for people. I might check how I could fix this in future separate PR (it might require rewritingnice_duration
plural support to something that works with more languages).I will probably also create separate parsing PR in the future.
I have already signed CLA but it is may not be approved yet.