Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove random commented out code #217

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Conversation

krisgesling
Copy link
Contributor

@krisgesling krisgesling commented Nov 25, 2021

Description

Minor cleanup - for some reason a nice_time function signature was left in as a comment this has been copied across to multiple languages.

Noticed when reviewing #212

Type of PR

  • Refactor of code (without functional changes)

Testing

No functional changes - tests should pass.

CLA

  • Yes

For some reason a nice_time function signature was left in as a
comment this has been copied across to multiple languages.
@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Nov 25, 2021
@krisgesling
Copy link
Contributor Author

As this literally doesn't touch any code - I'm going to merge it in if I hear no opposition in the next few days.

Left in as they can be useful for debugging
Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

@forslund
Copy link
Collaborator

Merging as indicated by previous comment by @krisgesling

@forslund forslund merged commit b76bc51 into master Jul 22, 2022
@forslund forslund deleted the refactor/remove-commented-code branch July 23, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants