-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: revise neovim's install section #1090
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking this work. It looks generally better than the old ancient document. There are some typos but we can fix them later.
docs/tinymist/frontend/neovim.typ
Outdated
formatterMode = "typstyle" | ||
``` | ||
== Preview | ||
There is work in progress to integrate #link("https://github.com/chomosuke/typst-preview.nvim")[typst-preview.nvim] directly into `tinymist`. In the meantime you can find can find installation and configuration instructions on that repo. This should be a shortterm solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we have introduced an announcement here that we will provide some plugin developed inside of tinymist repository, while we were only providing a sample plugin to integrate tinymist into LazyVim. I have a few questions:
- What's the position of the new plugin? Does it only replace the typst-preview.nvim?
- How do the replaced plugin authors think of it? Is it common or supported in (neo)vim community? Will they join or against to build an out-of-box new typst.nvim? We must at least discuss about it with chomosuke.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we could, imo we should push patches or changes to existing plugins to not force people to leave their old settings but still get benefit from our work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I agree that sounds good. I was wondering at the status of all of that, good to know progress is underway. I am not sure on how that integration will work I was assuming you had some deal what that plugin author. To me it makes sense to not have an external preview tool when there is potential for the lsp to have that feature, but I think the whole issue requires discussion.
btw, don't we need to pin the main file any more for tinymist in neovim? It seems that part is completely removed? |
I'm honestly not sure since currently the builtin preview does not work for me which is the main conflict when changing files. Using typst-preview.nvim I'm getting no issues because it is being handled under the hood for you. That project has everything we need to make tinymist integrate with neovim, but I'm still confused on the status of merging it. It says in the readme that it is a plugin for tinymist, and it uses tinymist itself under the hood. Bottom line is tinymist has to either copy everything over and merge that plugin, or just direct people to use it with a link. Most neovim LSP does hot have a preview builtin, LaTeX and markdown both have separate plugins, so it's not a huge deal to have these as different projects, it is a little weird though that the lsp has preview capability and we're bringing in another tool. As long as everything works and the docs are clear on it I don't think it's a huge problem. |
I am not talking about preview. |
I added the section "Working with Multiple-Files Projects" back. To tell what is a multiple-file project and the problem to solve, I also added a simple example to explain them. |
I added new instructions that are more up to date with neovim specs. There is still work to do to get all features working, and with the new addition of the typst-nvim preview some things will change in the future. I made a note saying that, but wanted to get this out soon because of the confusion from people in issues and in the discord.