Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to Svelte 4 and SvelteKit 2, refactored most writable() instances #26

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

gnomefire
Copy link

@gnomefire gnomefire commented May 21, 2024

  • Migrated to svelte 4 and updated all packages.
  • Migrated to sveltekit 2
  • Refactored instances of Writable() (probably still more to do on this front, but it seems to be working)
  • Updated to use the newest node version (20.11.0)
  • Updated package manager to pnpm (this is just a personal preference for efficiency)

TODO:
update all outdated dependencies
MUCH MORE

Copy link

netlify bot commented May 21, 2024

Deploy Preview for svelte-babylon failed.

Name Link
🔨 Latest commit 9a00895
🔍 Latest deploy log https://app.netlify.com/sites/svelte-babylon/deploys/664c253ed8a5b80008739f7a

@gnomefire gnomefire closed this May 21, 2024
@gnomefire gnomefire reopened this May 21, 2024
@gnomefire gnomefire changed the title Migrated to Svelte 4, refactored most writable() instances Migrated to Svelte 4 and SvelteKit 2, refactored most writable() instances May 21, 2024
@Myrmod
Copy link
Owner

Myrmod commented May 21, 2024

  • Migrated to svelte 4 and updated all packages.
  • Migrated to sveltekit 2
  • Refactored instances of Writable() (probably still more to do on this front, but it seems to be working)
  • Updated to use the newest node version (20.11.0)
  • Updated package manager to pnpm (this is just a personal preference for efficiency)

TODO: update all outdated dependencies MUCH MORE

Thank you for the updates and suggestions!

I have some notes though:

  • Currently we have to use Node 18, since Netlify only supports NodeJS up to that version.
  • The exports of JS files, instead of TS is intended and should remain. Not everyone uses TypeScript in their projects, and enforcing it in the package would make it harder to integrate the library in their projects. EDIT: DOESN'T MATTER, TypeScript is fine
  • The change from npm to pnpm is totally fine
  • do you really need @types/babylonjs?
  • what is this package.json.bkp for?

I haven't been able to look into the project and svelte in a while, so I'm sorry for the missing updates. I'll try to assist you in updating as best I can.

Best regards and thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants