Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple logical validators #68

Open
wants to merge 46 commits into
base: research
Choose a base branch
from

Conversation

hrubaanna
Copy link

Current issue:

The application was crashing with two error types:
"The application panicked (crashed).

  1. Message: Cannot start a runtime from within a runtime. This happens because a function (like block_on) attempted to block the current thread while the thread is being used to drive asynchronous tasks.
  2. Message: core thread is not expected to stop: RecvError(())

Mulitple locations in block_handler.rs, spawned.rs -> everywhere with a block_on or similar blocking functions:
Location: mysticeti-core/src/block_handler.rs:476
Location: mysticeti-core/src/block_handler.rs:169
Location: mysticeti-core/src/block_handler.rs:229
Location: mysticeti/mysticeti-core/src/core_thread/spawned.rs:121
Location: mysticeti/mysticeti-core/src/core_thread/spawned.rs:106
Location: mysticeti/mysticeti-core/src/core_thread/spawned.rs:81

I converted many of these functions into asynchronous, which stopped the errors, but now either:

  • the BlockHandler begins receiving txs from BlockGenerator channel OR;
  • the NetworkSyncer is started and Core thread is started, allowing to Syncer trying to commit new blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant