Upgrade Errors for struct enum functions #20151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
upgrade-errors-struct-enum-functions
branch
from
0cdd0c3
to
6149e81
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
jordanjennings-mysten
force-pushed
the
upgrade-errors-struct-enum-functions
branch
from
6149e81
to
0bf7e4a
Compare
jordanjennings-mysten
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
reviewed
Nov 12, 2024
| @@ -15,6 +15,7 @@ pub mod key_identity; | |||
| pub mod keytool; | |||
| pub mod shell; | |||
| pub mod sui_commands; | |||
| mod upgrade_compatibility; | |||
There was a problem hiding this comment.
What does this change do?
| = Enums are part of a module's public interface and cannot be changed during an upgrade | ||
| = Restore the original enum's variants for enum 'EnumChangeVariant' including the ordering. | ||
|
|
||
| error[Compatibility E01002]: type mismatch |
There was a problem hiding this comment.
Is this really a "type mismatch"?
| 59 │ B { b: u8 }, // added | ||
| │ ^^^^^^^^^^^ New unexpected variant 'B'. | ||
| │ | ||
| = Enums are part of a module's public interface and cannot be changed during an upgrade. |
There was a problem hiding this comment.
I'm seeing some weird characters at the end of these lines on GitHub. Any idea what is up here?
| Vec::<(Loc, String)>::new(), | ||
| vec
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add struct, enum and function errors to upgrade errors, leaves out type params to give it, it's own PR.
Test plan
snapshots
Release notes
no effect until enabled
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.