Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run w/o MABwiser in the CI #163

Closed
N-Wouda opened this issue Aug 3, 2023 · 1 comment · Fixed by #176
Closed

Run w/o MABwiser in the CI #163

N-Wouda opened this issue Aug 3, 2023 · 1 comment · Fixed by #176
Assignees
@N-Wouda
Labels
enhancement New feature or request maintenance Maintenance chore

Comments

@N-Wouda
Copy link
Owner

N-Wouda commented Aug 3, 2023

See for example #162. It's tricky to verify everything also works without MABwiser. We should do a CI run where it is not installed by default to make sure everything also works without the dependency.

This will probably need to mark some tests as skippable if mabwiser is not available.
@N-Wouda N-Wouda added enhancement New feature or request maintenance Maintenance chore labels Aug 3, 2023
@N-Wouda N-Wouda self-assigned this Aug 3, 2023
@N-Wouda N-Wouda mentioned this issue Aug 3, 2023
Merged
@N-Wouda
Copy link
Owner Author

N-Wouda commented Oct 21, 2024 •
edited
Loading

I guess one run without MABWiser should suffice. We can skip the relevant tests when we do not find MABWiser, using pytest's skipif marker.

@N-Wouda N-Wouda mentioned this issue Oct 21, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@N-Wouda N-Wouda

Labels
enhancement New feature or request maintenance Maintenance chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sometimes run with and without MABWiser N-Wouda/ALNS
1 participant
@N-Wouda