Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating inputs for MABSelector to new types LearningPolicyType and NeighboorhoodPolicyType from the new version of mabwiser #162

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

AshishPvjs
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #162 (1ad4f77) into master (1960a0e) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #162   +/-   ##
=======================================
  Coverage   99.46%   99.46%           
=======================================
  Files          30       30           
  Lines         747      747           
=======================================
  Hits          743      743           
  Misses          4        4           
Files Changed Coverage Δ
alns/select/MABSelector.py 92.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AshishPvjs
Copy link
Contributor Author

@skadio

Copy link
Owner

@N-Wouda N-Wouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AshishPvjs, thanks for the PR! Looks good to me, except for the one issue with the types. I'll commit that and then merge this in.

alns/select/MABSelector.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
Copy link

@skadio skadio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank approve --

@N-Wouda N-Wouda merged commit 0477e1e into N-Wouda:master Aug 3, 2023
7 checks passed
@AshishPvjs
Copy link
Contributor Author

Thank you @N-Wouda.

@skadio
Copy link

skadio commented Aug 3, 2023

thank you as well @AshishPvjs --also for making the change in MABWiser side

@N-Wouda
Copy link
Owner

N-Wouda commented Aug 3, 2023

New release is underway: https://github.com/N-Wouda/ALNS/actions/runs/5755818928. Should hit PyPI in a few minutes! 🚀

@N-Wouda
Copy link
Owner

N-Wouda commented Aug 3, 2023

alns==5.3.1 now requires mabwiser >= 2.7.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants