Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary ninja sig_provider #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Binary ninja sig_provider #1

wants to merge 3 commits into from

Conversation

0xFAC0
Copy link

@0xFAC0 0xFAC0 commented Jan 31, 2024

Binary Ninja sig_provider implementing https://github.com/Vector35/sigkit

@@ -11,6 +11,8 @@
import pytz
from rich import print

from rustbininfo.sig_providers.binja.binja import BinjaProvider
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use relative imports

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, try / catch the import since it relies on binary ninja

@@ -50,6 +52,9 @@ def parse_args():
ida_parser.add_argument("idat_path", type=pathlib.Path)
ida_parser.add_argument("sigmake_path", type=pathlib.Path)

binja_parser = sig_subparsers.add_parser("Binja")
binja_parser.add_argument("--multiprocess", type=bool, required=False, default=False) # Might sometimes Nuke PC
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change comment

@@ -11,6 +11,8 @@
import pytz
from rich import print

from rustbininfo.sig_providers.binja.binja import BinjaProvider
from rustbininfo.sig_providers.binja.model import ConfigBinja
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

relative import and try catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants