-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary ninja sig_provider #1
base: master
Are you sure you want to change the base?
Conversation
@@ -11,6 +11,8 @@ | |||
import pytz | |||
from rich import print | |||
|
|||
from rustbininfo.sig_providers.binja.binja import BinjaProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use relative imports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, try / catch the import since it relies on binary ninja
@@ -50,6 +52,9 @@ def parse_args(): | |||
ida_parser.add_argument("idat_path", type=pathlib.Path) | |||
ida_parser.add_argument("sigmake_path", type=pathlib.Path) | |||
|
|||
binja_parser = sig_subparsers.add_parser("Binja") | |||
binja_parser.add_argument("--multiprocess", type=bool, required=False, default=False) # Might sometimes Nuke PC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change comment
@@ -11,6 +11,8 @@ | |||
import pytz | |||
from rich import print | |||
|
|||
from rustbininfo.sig_providers.binja.binja import BinjaProvider | |||
from rustbininfo.sig_providers.binja.model import ConfigBinja |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relative import and try catch
Binary Ninja sig_provider implementing https://github.com/Vector35/sigkit