-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory cache #762
Fix memory cache #762
Conversation
… have tiles that are still loading
cc @AnthonyGlt - this should be ready if you want to test it a bit. I just have to write some more tests / fix the existing ones. In simpler terms, the changes are:
|
PR should be ready, now. |
src/utilities/LRUCache.js
Outdated
// loaded are subject to being disposed early even if the are marked as used if the cache is full above its | ||
// max size limits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit There is a word missing here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the test check is a good addition 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - just reworded it. Let me know once you think everything looks good and we can get this merged and a new version published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
We got to juggle with the notions of used
and loaded
but at the end, it makes the cache management more subtle.
Well done :D
Thanks - yeah nomenclature could probably use some work but I think the functionality is good. |
Fix #761