Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update starter kit for detect secrets and pre-commit #93

Closed
wants to merge 4 commits into from

Conversation

perryzjc
Copy link
Member

@perryzjc perryzjc commented Apr 20, 2023

Purpose

Proposed Changes

  • [ADD] Additional pages for starter kit of secret detection

Issues

Testing

  • Unit test files are included in the plug-ins folder. Current code passes all the unit tests.
  • The Plug-ins also works at other sample repository.

@perryzjc perryzjc closed this Apr 25, 2023
@riverma riverma reopened this May 2, 2023
Copy link
Contributor

@jpl-jengelke jpl-jengelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed this PR previously and decided to close it in favor of a more targeted PR:

  • Move secrets detection, which is a kind of "Static Application Security Testing" to the Continuous Testing section (see https://github.com/NASA-AMMOS/slim/tree/issue_89)
  • Move functional files into Python Starter Kit repo
    • .pre-commit-config.yaml (per example)
    • .detect-secrets/filters or .detect-secrets/plugins directories to hold custom configs
  • PR to main detect secrets repo with tests and custom plugins so that they may integrate the changes.
  • Template for write-up was created in the above branch

Basically the body of these changes will be reflected differently in the new PR from the issue_89 branch. ... But the changes will be part of the work committed in that branch.

@riverma
Copy link
Collaborator

riverma commented Jun 10, 2023

This is an outdated PR. Please see more relevant / updated one here: #95

@riverma riverma closed this Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants