Ability to click on the affected URLs of a pattern and see which URLs have been affected #1038

Kirandawadi · 2024-09-26T00:36:21Z

Added ability to click on the affected urls of a pattern and see which urls have been affected. This works for Include Patterns, Exclude Patterns, Title Patterns and Document Type Patterns.

…terns

sde_indexing_helper/templates/sde_collections/affected_urls.html

code-geek

Mostly good. I have a few comments. Lmk when you push changes and I can take a look again. Thanks!

code-geek · 2024-09-26T18:07:44Z

sde_collections/views.py

+    def get_queryset(self):
+
+        if "exclude-pattern" in self.request.path:
+            self.pattern = ExcludePattern.objects.get(id=self.kwargs["id"])
+            self.pattern_type = "Exclude"
+        elif "include-pattern" in self.request.path:
+            self.pattern = IncludePattern.objects.get(id=self.kwargs["id"])
+            self.pattern_type = "Include"
+        elif "title-pattern" in self.request.path:
+            self.pattern = TitlePattern.objects.get(id=self.kwargs["id"])
+            self.pattern_type = "Title"
+        elif "document-type-pattern" in self.request.path:
+            self.pattern = DocumentTypePattern.objects.get(id=self.kwargs["id"])
+            self.pattern_type = "Document Type"
+        else:
+            return super().get_queryset()
+
+        queryset = self.pattern.matched_urls()
+        return queryset


Please create a base class-based view and inherit from it to create multiple views instead of using these if conditions in a single view.

created base-class view which will be inherited by multiple views.

code-geek · 2024-09-26T18:08:39Z

sde_indexing_helper/static/css/affected_urls.css

+
+
+


This file needs linting. VS Code should come with a default linter for CSS files. Maybe you can run "Format files" with Ctrl+Shift+P

solved formatting issue.

code-geek · 2024-09-26T18:09:46Z

sde_indexing_helper/static/css/affected_urls.css

These are a lot of additional CSS rules on top of existing ones. Are these all required/used?

Refactored the affected_urls.css to only use required CSS declarations.

code-geek · 2024-09-26T18:10:17Z

sde_indexing_helper/static/js/affected_urls.js

+  },
+
+  })


File needs linting. Please use VS Code's "Format files" feature.

You might consider enabling "Format files on save"

Solved formatting issue.

code-geek · 2024-09-26T18:11:14Z

sde_indexing_helper/static/js/affected_urls.js

+function handleIncludeIndividualUrlClick() {
+    $("body").on("click", ".include-url-btn", function () {
+
+    const i = this.querySelector('i');


Think this deserves a more descriptive variable name? I'm not sure what i is from querySelector.

This function is part of the "Include/Exclude URL" feature on the "Affected URLs" page. Currently, the basic version of the "Affected URLs" page has been pushed, which does not incorporate this feature yet. I will address this in my next commit.

code-geek · 2024-09-26T18:11:56Z

sde_indexing_helper/static/js/candidate_url_list.js

+        render: function (data, type, row) {
+          return `<div style="display: flex; align-items: center; justify-content: center;">
+                    <span style="min-width: 50px; text-align: right; padding-right: 10px;">${data}</span>
+                    <button type="button" class="btn btn-sm view-exclude-pattern-urls" data-row-id="${row.id}">
+                      <i class="fa fa-eye"></i>
+                    </button>
+                  </div>`;
+        },
      },


Let's fix the formatting on these lines

Same comment for all the other renders we have.

Solved the formatting issue.

code-geek · 2024-09-26T18:12:47Z

sde_indexing_helper/static/js/candidate_url_list.js

+function handleShowAffectedURLsListButtonClick() {
+  $("body").on("click", ".view-exclude-pattern-urls", function () {
+    var matchPatternId = $(this).data("row-id");
+    console.log(matchPatternId);


Do we need all these console.log statements in production? If not, consider removing them.

Removed the debugging lines.

code-geek · 2024-09-26T18:13:18Z

sde_indexing_helper/templates/sde_collections/affected_urls.html

+                    <!-- <th scope="col" class="text-center col-3">
+                        {% if pattern_type == "Include" %}
+                            Exclude URL
+                        {% elif pattern_type == "Exclude" %}
+                            Include URL
+                        {% endif %}
+                    </th> -->


Let's get rid of commented out code if we don't need it.

Removed the unnecessary comments block.

code-geek · 2024-09-26T18:13:41Z

sde_indexing_helper/templates/sde_collections/affected_urls.html

+                        <!-- <td class="col-3 text-center data-sort="0">
+                            {% if pattern_type == "Exclude" %}
+                                <a class="include-url-btn" data-url-id="{{ url.id }}" value = "{{url.url}}">
+                                {% if url.is_included %}
+                                    <i class="material-icons tick-mark" style="color: green">check</i></a>
+                                {% else %}
+                                <i class="material-icons cross-mark" style="color: red">close</i></a>
+                                {% endif %}
+                            {% elif pattern_type == "Include" %}
+                                <a class="exclude-url-btn" data-url-id="{{ url.id }}" value = "{{url.url}}">
+                                {% if url.is_excluded %}
+                                    <i class="material-icons tick-mark" style="color: green">check</i></a>
+                                {% else %}
+                                <i class="material-icons cross-mark" style="color: red">close</i></a>
+                                {% endif %}
+                            {% endif %}
+                        </td> -->


Do we need these? If not, let's remove them.

Removed the unnecessary comments block.

for more information, see https://pre-commit.ci

…ion added)

for more information, see https://pre-commit.ci

Kirandawadi added 6 commits September 25, 2024 19:28

Add 'Show Affected URLs' button and configure click handler

933852b

Add necessary files for 'Affected URLs' page

b9d2385

Add DataTables features to the page

e89eaa1

Affected URLs page for excluded patterns working properly

194929a

add view affected urls button to title patterns and document-type pat…

b15410e

…terns

finalise the affected urls page for all the pattern types

7a279fc

Kirandawadi linked an issue Sep 26, 2024 that may be closed by this pull request

Ability to click on the affected URLs of a pattern and see which URLs have been affected #1009

Open

github-advanced-security bot found potential problems Sep 26, 2024

View reviewed changes

sde_indexing_helper/templates/sde_collections/affected_urls.html Fixed Show fixed Hide fixed

sde_indexing_helper/templates/sde_collections/affected_urls.html Fixed Show fixed Hide fixed

sde_indexing_helper/templates/sde_collections/affected_urls.html Fixed Show fixed Hide fixed

Kirandawadi requested a review from code-geek September 26, 2024 01:13

code-geek changed the title ~~1009 ability to click on the affected urls of a pattern and see which urls have been affected~~ Ability to click on the affected URLs of a pattern and see which URLs have been affected Sep 26, 2024

code-geek suggested changes Sep 26, 2024

View reviewed changes

Kirandawadi added 5 commits September 26, 2024 15:13

Refactor AffectedURLsListView into pattern-specific views

e736d2c

remove unnecessary comments and format code

242d414

add integrity check to contents loaded from CDN

32ed7f8

remove unnecessary css declarations

74e074a

remove ordering functionality from second row of the datatable

dad63b0

Kirandawadi force-pushed the 1009-ability-to-click-on-the-affected-urls-of-a-pattern-and-see-which-urls-have-been-affected branch from d30541e to dad63b0 Compare September 27, 2024 00:41

pre-commit-ci bot and others added 3 commits September 27, 2024 00:42

[pre-commit.ci] auto fixes from pre-commit.com hooks

11959fc

for more information, see https://pre-commit.ci

fix issues shown by flake8

e68b50e

[pre-commit.ci] auto fixes from pre-commit.com hooks

c545b8c

for more information, see https://pre-commit.ci

Kirandawadi requested a review from code-geek September 27, 2024 01:15

added include-pattern functionality; fixed candidate-urls-api (inclus…

4205c1d

…ion added)

Kirandawadi requested a review from bishwaspraveen September 30, 2024 22:01

Kirandawadi and others added 7 commits October 10, 2024 14:06

remove 'add pattern' button from unnecessary pages

42cdda0

add serializer class to affected urls functionalities

6b21213

add datatables reload() feature to skip unnecessary ui modifications

9d666b2

fix ajax issues of datatable

6ec4943

add 'include pattern' feature on right mouse click

37bdb7c

[pre-commit.ci] auto fixes from pre-commit.com hooks

1056ac9

for more information, see https://pre-commit.ci

fix flake8 issues

525e6a2

Kirandawadi mentioned this pull request Oct 21, 2024

Feature to include URL patterns #1007

Open

Kirandawadi and others added 4 commits October 21, 2024 14:00

add checks to see if include pattern already exists

597252c

fix 'exclude' column of 'Candidate URLs' page

4fd628b

fix 'affected urls' count

1179641

[pre-commit.ci] auto fixes from pre-commit.com hooks

000153c

for more information, see https://pre-commit.ci

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ability to click on the affected URLs of a pattern and see which URLs have been affected #1038

Ability to click on the affected URLs of a pattern and see which URLs have been affected #1038

Kirandawadi commented Sep 26, 2024 •

edited

Loading

code-geek left a comment

code-geek Sep 26, 2024

Kirandawadi Sep 27, 2024

code-geek Sep 26, 2024

Kirandawadi Sep 27, 2024

code-geek Sep 26, 2024

Kirandawadi Sep 27, 2024

code-geek Sep 26, 2024

code-geek Sep 26, 2024

Kirandawadi Sep 27, 2024

code-geek Sep 26, 2024

Kirandawadi Sep 27, 2024

code-geek Sep 26, 2024

code-geek Sep 26, 2024

Kirandawadi Sep 27, 2024

code-geek Sep 26, 2024

Kirandawadi Sep 27, 2024

code-geek Sep 26, 2024

Kirandawadi Sep 27, 2024

code-geek Sep 26, 2024

Kirandawadi Sep 27, 2024

Ability to click on the affected URLs of a pattern and see which URLs have been affected #1038

Are you sure you want to change the base?

Ability to click on the affected URLs of a pattern and see which URLs have been affected #1038

Conversation

Kirandawadi commented Sep 26, 2024 • edited Loading

code-geek left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kirandawadi commented Sep 26, 2024 •

edited

Loading