Add basic JSON indexing template #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-geek
suggested changes
Feb 6, 2024
| <ToBeIndexed>true</ToBeIndexed> | ||
| <Name>url_list</Name> | ||
| <Method>GET</Method> | ||
| <Source>https://sde-indexing-helper.nasa-impact.net/candidate-urls-api/solar_system_exploration/</Source> |
There was a problem hiding this comment.
If this is meant to be a template, should we get rid of specific values like this one?
| <Root>$.results</Root> | ||
| <Description></Description> | ||
| <WaitBeforeNext></WaitBeforeNext> | ||
| <NextPageExpression>https://sde-indexing-helper.nasa-impact.net/candidate-urls-api/solar_system_exploration/?format=json&page={Add(datasource.url_list.pagenumber,1)}</NextPageExpression> |
There was a problem hiding this comment.
This as well. But maybe we add a variable where "solar_system_exploration" is.
| <Description></Description> | ||
| <WaitBeforeNext></WaitBeforeNext> | ||
| <NextPageExpression>https://sde-indexing-helper.nasa-impact.net/candidate-urls-api/solar_system_exploration/?format=json&page={Add(datasource.url_list.pagenumber,1)}</NextPageExpression> | ||
| <EndPageExpression>datasource.url_list.pagenumber=132</EndPageExpression> |
There was a problem hiding this comment.
Why 132? Is there a way to add a comment above this line?
There was a problem hiding this comment.
might need to do a little bit more work to have a reliable way of calculating the actual pagenumber
| <Name>data2</Name> | ||
| <Method>GET</Method> | ||
| <Source>$.data</Source> | ||
| <Root>$.Spase</Root> |
There was a problem hiding this comment.
this is a weird sinequa artifact. it doesn't actually appear in the admin
CarsonDavis
commented
Feb 6, 2024
CarsonDavis
commented
Feb 6, 2024
CarsonDavis
commented
Feb 6, 2024
code-geek
approved these changes
Feb 6, 2024
code-geek
changed the title
CarsonDavis
deleted the
585-create-json-connector-for-url-based-indexing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.