Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earth dot gov carousel #149

Open
wants to merge 25 commits into
base: develop
Choose a base branch
from
Open

Earth dot gov carousel #149

wants to merge 25 commits into from

Conversation

freitagb
Copy link

Why are you creating this Pull Request?

With a global sea level portal we have been requested to add another link to highlight the new portal. Since we have 3 featured portals we requested integration of the carousel feature for Earth.gov. This PR configures the carousel as requested by HQ leadership

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for earth-information-center ready!

Name Link
🔨 Latest commit 6921bd2
🔍 Latest deploy log https://app.netlify.com/sites/earth-information-center/deploys/673657ce8864a60008cf9be1
😎 Deploy Preview https://deploy-preview-149--earth-information-center.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The carousel generally works, but a few things need fixing:

  1. The link to sealevel does not work (see comment). A trailing slash seems to fix it.

  2. There seem to be a bunch of very similar sealevel media images added - are they all needed?

  3. The carousel needs to be better aligned with the title above it and other elements on the page, perhaps by using the grid differently. We might need to ping an engineer to help fix this - on first look, it is not obvious to me how.

    image

overrides/home/carousel/items.js Outdated Show resolved Hide resolved
@freitagb
Copy link
Author

  1. I committed your change on this. Good catch
  2. I don't believe there's a way to add text on the carousel card so the similar images are one with text for the carousel and one without - though we may not need the ones without text in the future. Will come back to this
  3. Yeah - i was struggling with that too. I think it's okay on the landing page (will defer to designers) but the alignment does not look good on */stories/sea-level-rise page.

The carousel generally works, but a few things need fixing:

  1. The link to sealevel does not work (see comment). A trailing slash seems to fix it.
  2. There seem to be a bunch of very similar sealevel media images added - are they all needed?
  3. The carousel needs to be better aligned with the title above it and other elements on the page, perhaps by using the grid differently. We might need to ping an engineer to help fix this - on first look, it is not obvious to me how.
    image

Copy link
Collaborator

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the links now work and alignment is decent.

On the home page, it looks a bit busy with different width blocks. But unless you can make the Carousel a couple of columns wider to match the elements above, I think there is no better way of handling these different elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants