Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content: GST CO2 #291

Closed
wants to merge 4 commits into from
Closed

Content: GST CO2 #291

wants to merge 4 commits into from

Conversation

slesaad
Copy link
Member

@slesaad slesaad commented Jul 26, 2023

Adding content

Dataset configuration for GST CO2 budgets


Content checklist

Check the Content Documentation for more details.

Any content

  • Cover image with proper attribution (when relevant) is present.
  • Cover images do not contain any text (they're used as a background and text may not be readable).
  • All images are not too big/heavy. As a general rule of thumb, they should not weigh more than 500KB, or be larger than 2000px. See the media guide for more info.
  • Content was added using the available MDX Blocks.

Datasets

Discoveries

@netlify
Copy link

netlify bot commented Jul 26, 2023

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 655c870
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/64f07a8f0e1fe40008eafe1f
😎 Deploy Preview https://deploy-preview-291--visex.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aboydnw
Copy link
Contributor

aboydnw commented Jul 27, 2023

Looks pretty good to me. @slesaad have you been able to review the color scales with Brendan or Matt?

@slesaad
Copy link
Member Author

slesaad commented Jul 27, 2023

@aboydnw i've responded to the email thread for them to review the content

@danielfdsilva
Copy link
Collaborator

@slesaad This content will now have to be updated according to new approach for taxonomies.
See the content migration guide on the veda-ui release.

@j08lue
Copy link
Contributor

j08lue commented Aug 28, 2023

I updated the taxonomy definitions in a PR against this branch, @slesaad. Merging that should get this PR here in shape for merging, too. Please review and merge if it looks right, @slesaad.

@danielfdsilva
Copy link
Collaborator

@j08lue @slesaad I just rebased this on top of develop integrating the changes that Jonas made. This was the diff is smaller, making it easier to review.

@j08lue
Copy link
Contributor

j08lue commented Aug 31, 2023

Thanks, @danielfdsilva. @slesaad - I'll leave it to you to decide when this is ready for merging from a content perspective. Code-wise, it should be good now.

Copy link
Contributor

@j08lue j08lue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of completeness and configuration. Can't judge content.

@j08lue j08lue removed the request for review from aboydnw August 31, 2023 11:48
@slesaad slesaad closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants