Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content] Black Belt Story #446

Merged
merged 32 commits into from
Nov 12, 2024
Merged

[Content] Black Belt Story #446

merged 32 commits into from
Nov 12, 2024

Conversation

acblackford
Copy link
Contributor

Why are you creating this Pull Request?

Copy link

netlify bot commented Sep 23, 2024

Deploy Preview for visex ready!

Name Link
🔨 Latest commit 975c956
🔍 Latest deploy log https://app.netlify.com/sites/visex/deploys/673385c2447ee900086c9d30
😎 Deploy Preview https://deploy-preview-446--visex.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@acblackford
Copy link
Contributor Author

@anayeaye @slesaad the soil texture dataset in this PR is ready for prod

Copy link
Collaborator

@anayeaye anayeaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove space and try trigger deploy preview

@slesaad
Copy link
Member

slesaad commented Sep 25, 2024

this image is looking too small now
image

also, for the line charts used, using the <Chart> component will be better than using images

@acblackford acblackford changed the title black belt story [Content] Black Belt Story Sep 30, 2024
Copy link
Contributor

@mahineelam mahineelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edits to text

@jerikac
Copy link
Contributor

jerikac commented Oct 24, 2024

Hey Code Owners - this PR is ready for review!

Copy link
Contributor

@aboydnw aboydnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@acblackford merge when ready

@hanbyul-here @snmln let's include this in the release today if possible

@aboydnw
Copy link
Contributor

aboydnw commented Oct 29, 2024

Actually, nevermind @hanbyul-here @snmln I think this story is still dependent on this ticket: NASA-IMPACT/veda-backend#441

@jerikac
Copy link
Contributor

jerikac commented Nov 6, 2024

Now that #441 is closed, can we push this story to Prod? @aboydnw

@aboydnw
Copy link
Contributor

aboydnw commented Nov 7, 2024

@mahineelam looks like you've been making the bulk of the changes. when you're ready go ahead and merge.

I just did another quick smoke test and looks good. If you merge here then we can plan to release to production the week of Nov 18th

@aboydnw
Copy link
Contributor

aboydnw commented Nov 7, 2024

@mahineelam based on that proposed release to production then you might want to change the published date before merging

jerikac and others added 2 commits November 7, 2024 15:23
Original Pub date was old -- updated to sync with next VEDA release (Nov11 or Nov12, 2024)
@dzole0311 dzole0311 merged commit 349fafc into develop Nov 12, 2024
6 checks passed
@dzole0311 dzole0311 deleted the black-belt branch November 12, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants