Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge recent changes from dev and VSCode installation into main #34

Merged
merged 13 commits into from
Oct 1, 2024
Merged

Conversation

ateucher
Copy link
Member

This takes the work that @betolink had done in the dev branch (which is currently the image used in the hub) and recent work merged into main from #32, #33, etc

@ateucher
Copy link
Member Author

ateucher commented Jun 27, 2024

@betolink this mostly looks good except that VSCode can't find the main Jupyter kernel (Running BYOI with openscapes/python:693163b), only opendap.

It is there:

(notebook) jovyan@jupyter-ateucher:~$ jupyter kernelspec list
Available kernels:
  opendap    /srv/conda/envs/notebook/share/jupyter/kernels/opendap
  python3    /srv/conda/envs/notebook/share/jupyter/kernels/python3

but VSCode doesn't see it

image.

I'm trying to track down why, but if you have any tips I'm happy to hear them!

@ateucher
Copy link
Member Author

ateucher commented Sep 11, 2024

@betolink I'm just coming back to this, would be good to get the image updated. I see you're thinking about it too (#35 (comment))

I updated the environment again, I don't know how important the pinned versions are on some libraries (e.g., conda-lock, netcdf==1.6.5 in opendap), and should we update python (it's currently pinned to 3.10)?

@ateucher
Copy link
Member Author

ateucher commented Sep 11, 2024

Also - VSCode seems to be behaving better now, the notebook environment seems to be default, and opendap is an option:

image

And the opendap kernel is also available:

image

The extensions are installed and working as they should

@betolink
Copy link
Member

betolink commented Oct 1, 2024

Sorry for the super delayed time to check this, I'm merging it and I think we can address the VSCode integration as a separate issue. @ateucher I think we should include the same con-lock on actions that CryoCloud has so we don't have to do it ourselves. And another thing we might want to take a look at is how can we use something like dependabot to update our packages and open PRs, I haven't looked in a while if there is a way to integrate it with Conda environments.

@betolink betolink merged commit 14b5e99 into main Oct 1, 2024
1 check passed
@ateucher
Copy link
Member Author

ateucher commented Oct 1, 2024

Thanks @betolink. I think the vscode integration is now not bad, though some real-world user testing will tell us for sure.

same con-lock on actions that CryoCloud has so we don't have to do it ourselves.

I like that idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants