Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified wrf/wrf-chem model_mod #741

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Unified wrf/wrf-chem model_mod #741

wants to merge 7 commits into from

Conversation

hkershaw-brown
Copy link
Member

Description:

Refactored WRF model mod for WRF & WRF CHEM.
Namelist selectable QTYS, see #404 for details.

Created a wrf_unified model directory. This is to allow concurrent development on wrf and wrf_unified.
wrf_unified/model_mod is ~4500 less than the wrf/model_mod and this is a bit of a headache for keeping up-to-date with main (easy to miss changes in such differing code).

See pull #683 for original pull request
wrf-wrf-chem branch available at https://github.com/hkershaw-brown/DART/tree/wrf-wrf-chem

Fixes issue

Fixes #404
Partial #359 (WRF)
Partial #624 (WRF)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.
Bitwise tests during refactoring

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

hkershaw-brown and others added 4 commits September 26, 2024 13:35
New model_mod directory so development can happen concurrently on
wrf and wrf_unified.
Original pull request #683
@hkershaw-brown
Copy link
Member Author

For un reviewed atmos-chem forward operators see #743

@hkershaw-brown hkershaw-brown added the wrf Weather Research & Forecasting Model label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
atmos-chem wrf Weather Research & Forecasting Model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat req: Refactor wrf model_mod and models/wrf directory, unify WRF/WRF-CHEM
1 participant