mpas_atm refactor to use state structure module #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note still have clamp or fail being read but not used #624
Removed state_vector_to_boundary_file and update_wind_components so I can compile with debugging flags
Is the rbf code depricated #753 (comment)
see comment #753 (comment) Remove not used variables: add_static_data_to_diags - not used ew_boundary_type, ns_boundary_type -not used Shortened some very verbose comments.
#753 (comment) removed done todo comment
statevector_to_boundary_file and statevector_to_analysis file need to be done.
todo: the pressure on edges
set ids array to length nc rather than 3
Q. Are there any surface obs that are not required for RTTOV?
QTY_CLOUD_FRACTION is also limited to 1
|
mpas code from MPAS-Model in DART repo is missing the MPAS-Model is missing the LICENCE. |
moved MPAS-model code to a directory with the LICENCE for the code from https://github.com/MPAS-Dev/MPAS-Model/blob/master/LICENSE fixes #781
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor mpas_atm model_mod to use state_structure, remove progvar to vector.
Fixes issue
Various mpas_atm issues, notes in #753
fixes #523,
fixes #389
fixes #781
#624, #768
note on subroutines, functions in mpas_atm model_mod refactor vs removed vs unchanged
Types of changes
Documentation changes needed?
Tests
MPAS model_mod_check and filter
Checklist for merging
Checklist for release
Testing Datasets