Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start using Accessibility link in the footer by bumping koru-jekyll theme version from 1.0.27 to 1.0.41 #68

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

erogluorhan
Copy link
Collaborator

Closes #67

Start using version 1.0.41 of koru-jekyll.

This is essentially for getting the #67 addressed, but may also add other features happened in between the older and newer versions.

Copy link
Contributor

@kafitzgerald kafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview looks good!

@erogluorhan
Copy link
Collaborator Author

@jukent @kafitzgerald

FYI: Locally confirming if this PR succeeds is a bit configurationally costly, but as a workaround, I just switched Pages settings to deploy the site from this branch and confirmed that site was built successfully and with the Accessibility link, see below:

image

Then, switched it back to building from gh-pages

@erogluorhan
Copy link
Collaborator Author

Preview looks good!

Is there a preview as part of the actions? I couldn't see any.

@erogluorhan erogluorhan merged commit 73703c1 into gh-pages Jan 17, 2024
3 checks passed
@kafitzgerald
Copy link
Contributor

Preview looks good!

Is there a preview as part of the actions? I couldn't see any.

Ah, maybe I just saw your deployment. Regardless, looks good.

@erogluorhan erogluorhan deleted the update_theme_version branch March 4, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a web accessibility link
2 participants