More review fixes

scripts/ccpp_suite.py

@@ -683,7 +683,6 @@ def __init__(self, sdfs, host_model, scheme_headers, run_env):
         # end for
         # We will need the correct names for errmsg and errcode
         evar = self.host_model.find_variable(standard_name='ccpp_error_message')
-        subst_dict = {'intent':'out'}
         if evar is not None:
             self._errmsg_var = evar
         else:
@@ -749,7 +748,12 @@ def declare_inspection_interfaces(cls, ofile):
         ofile.write(f"public :: {API.__schemes_fname}", 1)
 
     def get_errinfo_names(self, base_only=False):
-        """Return a tuple of error output local names"""
+        """Return a tuple of error output local names.
+        If base_only==True, return only the name string of the variable.
+        If base_only=False, return the local name as a full reference.
+        If the error variables are intrinsic variables, this makes no
+        difference, however, for a DDT variable, the full reference is
+        <ddt_name>%<errvar_name> while the local name is just <errvar_name>."""
         if base_only:
             errmsg_name = self._errmsg_var.get_prop_value('local_name')
             errcode_name = self._errcode_var.get_prop_value('local_name')

test/ddthost_test/CMakeLists.txt

@@ -1,4 +1,4 @@
-CMAKE_MINIMUM_REQUIRED(VERSION 2.8)
+CMAKE_MINIMUM_REQUIRED(VERSION 3.15)
 PROJECT(test_host)
 ENABLE_LANGUAGE(Fortran)
 

test/ddthost_test/make_ddt.F90

@@ -58,7 +58,7 @@ subroutine make_ddt_run(cols, cole, O3, HNO3, vmr, errmsg, errflg)
               ', should be ', nbox
       else
          ! NOTE -- This is prototyping one approach to passing a large number of
-         ! chemical VMR values and is the predecssor for adding in methods and
+         ! chemical VMR values and is the predecessor for adding in methods and
          ! maybe nesting DDTs (especially for aerosols)
          vmr%vmr_array(cols:cole, 1) = O3(:)
          vmr%vmr_array(cols:cole, 2) = HNO3(:)